Skip to content

Adjust error_reporting to allow deprecation messages for 3.0 #12705

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2014
Merged

Adjust error_reporting to allow deprecation messages for 3.0 #12705

merged 1 commit into from
Nov 29, 2014

Conversation

davidfuhr
Copy link

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? yes
Tests pass? yes
Fixed tickets #12623
License MIT
Doc PR

@davidfuhr
Copy link
Author

Pre-requisite for #12623

@@ -7,6 +7,9 @@
bootstrap="autoload.php.dist"
>
<php>
<!-- Disable E_USER_DEPRECATED until 3.0 -->
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the expression that is equivalent to the number in the comment so that it looks less magical?

@magnusnordlander
Copy link
Contributor

This should also be in each component's phpunit.xml.dist, I should think it would be best to keep them all in this one PR?

@fabpot
Copy link
Member

fabpot commented Nov 29, 2014

@magnusnordlander right

@davidfuhr
Copy link
Author

@magnusnordlander @fabpot So one pull request including all phpunit.xml files for all components?

@fabpot
Copy link
Member

fabpot commented Nov 29, 2014

@davidfuhr yes

@fabpot
Copy link
Member

fabpot commented Nov 29, 2014

Thank you @davidfuhr.

@fabpot fabpot merged commit 11ba901 into symfony:2.7 Nov 29, 2014
fabpot added a commit that referenced this pull request Nov 29, 2014
… 3.0 (davidfuhr)

This PR was merged into the 2.7 branch.

Discussion
----------

Adjust error_reporting to allow deprecation messages for 3.0

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #12623
| License       | MIT
| Doc PR        |

Commits
-------

11ba901 Adjust error_reporting to allow deprecation messages for 3.0
@davidfuhr davidfuhr deleted the phpunit-error-reporting branch November 29, 2014 12:48
xabbuh added a commit to xabbuh/symfony that referenced this pull request Nov 29, 2014
This updates the PHPUnit configuration files that have not been
updated in symfony#12705.
fabpot added a commit that referenced this pull request Nov 29, 2014
This PR was merged into the 2.7 branch.

Discussion
----------

[PHPUnit] ignore E_USER_DEPRECATED notices

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

This updates the PHPUnit configuration files that have not been
updated in #12705.

Commits
-------

dcc1103 [PHPUnit] ignore E_USER_DEPRECATED notices
ostrolucky pushed a commit to ostrolucky/symfony that referenced this pull request Mar 25, 2018
This updates the PHPUnit configuration files that have not been
updated in symfony#12705.
jderusse pushed a commit to jderusse/symfony that referenced this pull request Dec 15, 2020
This updates the PHPUnit configuration files that have not been
updated in symfony#12705.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants