[Hackday][2.7] Added deprecation trigger #12717
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
amansilla
commented
Nov 29, 2014
amansilla
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | no |
| Fixed tickets | #12608 |
| License | MIT |
| Doc PR |
| @@ -203,6 +203,11 @@ public function getValuesForChoices(array $choices) | |||
| */ | |||
| public function getIndicesForChoices(array $choices) | |||
| { | |||
| trigger_error( | |||
| 'getIndicesForChoices() is deprecated since version 2.4 and will be removed in 3.0.', | |||
There was a problem hiding this comment.
Can you move the whole expression on one line?
|
@fabpot Done |
| @@ -203,6 +203,8 @@ public function getValuesForChoices(array $choices) | |||
| */ | |||
| public function getIndicesForChoices(array $choices) | |||
| { | |||
| trigger_error('getIndicesForChoices() is deprecated since version 2.4 and will be removed in 3.0.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
please tell about the concerned class, not only method
There was a problem hiding this comment.
@nicolas-grekas Do you need the hole class name with namespace included? or just short class name.
…List and LazyChoiceList
|
👍 |
|
The format of the message in this PR does not match the format we standardized. Thus, many ChoiceList implementations have been missed in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.