Skip to content

[2.3] Fixed dev-dependencies so component test suites pass #12838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

[2.3] Fixed dev-dependencies so component test suites pass #12838

wants to merge 1 commit into from

Conversation

GrahamCampbell
Copy link
Contributor

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets N/A
License MIT
Doc PR N/A
This pull request fixes the dev-dependencies so component test suites pass.

@xabbuh
Copy link
Member

xabbuh commented Dec 3, 2014

@GrahamCampbell What is the reason for this change? Tests should generally also pass with newer versions of the components.

@GrahamCampbell
Copy link
Contributor Author

@xabbuh The tests were failing before because of depreciation warnings. They are now all passing.

// cc @fabpot

@xabbuh
Copy link
Member

xabbuh commented Dec 4, 2014

@GrahamCampbell Maybe it's then a better idea to backport the changes to the PHPUnit configuration which hide deprecation errors (see #12705 and #12756)?

@stof
Copy link
Member

stof commented Dec 4, 2014

👍 for backporting the change

@GrahamCampbell
Copy link
Contributor Author

👍 for backporting the change actually. :)

@GrahamCampbell GrahamCampbell deleted the 2.3-components branch December 4, 2014 20:44
@xabbuh
Copy link
Member

xabbuh commented Dec 4, 2014

@GrahamCampbell Maybe it's even better to not backport them and do something better (see @stof's comment here).

@stof
Copy link
Member

stof commented Dec 10, 2014

@xabbuh for the 2.3 branch, it is fine to backport the change. the branch were we should avoid using the deprecated methods in our own code is 2.7, not 2.3

@xabbuh
Copy link
Member

xabbuh commented Dec 10, 2014

@stof Hm, good point.

@GrahamCampbell Do you want to do that?

@GrahamCampbell
Copy link
Contributor Author

I can do? Hard anyone else done this already, or am I good to send a pull?

@xabbuh
Copy link
Member

xabbuh commented Dec 19, 2014

@GrahamCampbell I think it's done in #13033.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants