Resolves #12623 [Hackday] [2.7] Add a deprecation note about Debug compo... #12724
Conversation
davidfuhr
commented
Nov 29, 2014
davidfuhr
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #12623 |
| License | MIT |
| Doc PR |
| public function __construct() | ||
| { | ||
| trigger_error( | ||
| 'Symfony\Component\HttpKernel\Debug\ErrorHandler is deprecated since version 2.3' |
There was a problem hiding this comment.
Can you move the whole expression on one line? Thanks.
|
The tests fail for because of the deprecation message: https://travis-ci.org/Flagbit/symfony/builds/42471888 Should the changes to phpunit.xml.dist also be applied to the Bridges and Bundles? Because #12705 only did this for the Components. @nicolas-grekas |
|
Right, we should also patch bundles and bridges. |
| @@ -22,4 +22,10 @@ | |||
| */ | |||
| class FatalErrorException extends DebugFatalErrorException | |||
| { | |||
| public function __construct($message, $code, $severity, $filename, $lineno, $traceOffset = null, $traceArgs = true) | |||
| { | |||
| trigger_error('Symfony\Component\HttpKernel\Exception\FatalErrorException is deprecated since version 2.3 and will be removed in 3.0. Use the same class from the Debug component instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Is a custom constructor necessary? Adding this just below the namespace should work too, right?
|
Moved trigger_error() statements below the namespace declaration. |
|
Thank you @davidfuhr. |
…bout Debug compo... (davidfuhr) This PR was merged into the 2.7 branch. Discussion ---------- Resolves #12623 [Hackday] [2.7] Add a deprecation note about Debug compo... | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | yes | Tests pass? | yes | Fixed tickets | #12623 | License | MIT | Doc PR | Commits ------- 5876f52 [Hackday] [2.7] Add a deprecation note about Debug component classes
