[PHPUnit] ignore E_USER_DEPRECATED notices #12756
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the PHPUnit configuration files that have not been updated in symfony#12705.
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Nov 29, 2014
This PR was merged into the 2.7 branch. Discussion ---------- [PHPUnit] ignore E_USER_DEPRECATED notices | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | This updates the PHPUnit configuration files that have not been updated in #12705. Commits ------- dcc1103 [PHPUnit] ignore E_USER_DEPRECATED notices
|
The drawback of this is that we hide the fact that normal usage of Symfony 2.7 triggers deprecation notices. What we did in Symfony 2.2 was to explicitly ignore the deprecation notices in tests relying on BC layers, but not in others. |
|
@stof That makes more sense to me too, but that would be a bit of work to accomplish (since these will be tests in many places). But if we did that work, we would also exactly know which tests are testing deprecated behavior. Do you have an example of where/how we did this in 2.2? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the PHPUnit configuration files that have not been
updated in #12705.