PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

mwversion: 1.44.0-wmf.24
reqId: cea0c222-d4fa-4a68-a102-e14f2d87df56
Find reqId in Logstash

normalized_message

[{reqId}] {exception_url}   PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated

Frame	Location	Call
from	/srv/mediawiki/php-1.44.0-wmf.24/includes/config/SiteConfiguration.php(513)
#0	[internal function]	MediaWiki\Exception\MWExceptionHandler::handleError(int, string, string, int)
#1	/srv/mediawiki/php-1.44.0-wmf.24/includes/config/SiteConfiguration.php(513)	str_ends_with(null, string)
#2	/srv/mediawiki/php-1.44.0-wmf.24/extensions/SecurePoll/includes/User/RemoteMWAuth.php(65)	MediaWiki\Config\SiteConfiguration->siteFromDB(null)
#3	/srv/mediawiki/php-1.44.0-wmf.24/extensions/SecurePoll/includes/User/Auth.php(181)	MediaWiki\Extension\SecurePoll\User\RemoteMWAuth->requestLogin(MediaWiki\Extension\SecurePoll\Entities\Election)
#4	/srv/mediawiki/php-1.44.0-wmf.24/extensions/SecurePoll/includes/Pages/LoginPage.php(31)	MediaWiki\Extension\SecurePoll\User\Auth->newRequestedSession(MediaWiki\Extension\SecurePoll\Entities\Election)
#5	/srv/mediawiki/php-1.44.0-wmf.24/extensions/SecurePoll/includes/SpecialSecurePoll.php(66)	MediaWiki\Extension\SecurePoll\Pages\LoginPage->execute(array)
#6	/srv/mediawiki/php-1.44.0-wmf.24/includes/specialpage/SpecialPage.php(729)	MediaWiki\Extension\SecurePoll\SpecialSecurePoll->execute(string)
#7	/srv/mediawiki/php-1.44.0-wmf.24/includes/specialpage/SpecialPageFactory.php(1738)	MediaWiki\SpecialPage\SpecialPage->run(string)
#8	/srv/mediawiki/php-1.44.0-wmf.24/includes/actions/ActionEntryPoint.php(499)	MediaWiki\SpecialPage\SpecialPageFactory->executePath(string, MediaWiki\Context\RequestContext)
#9	/srv/mediawiki/php-1.44.0-wmf.24/includes/actions/ActionEntryPoint.php(143)	MediaWiki\Actions\ActionEntryPoint->performRequest()
#10	/srv/mediawiki/php-1.44.0-wmf.24/includes/MediaWikiEntryPoint.php(202)	MediaWiki\Actions\ActionEntryPoint->execute()
#11	/srv/mediawiki/php-1.44.0-wmf.24/index.php(58)	MediaWiki\MediaWikiEntryPoint->run()
#12	/srv/mediawiki/w/index.php(3)	require(string)
#13	{main}

Impact

Notes

Details

Request URL: https://vote.wikimedia.org/wiki/Special:SecurePoll/login/1208

Subject	Repo	Branch	Lines +/-
Deprecate calling public methods of SiteConfiguration with incorrect typed args	mediawiki/core	master	+125 -0
SiteConfiguration::siteFromDb: Don't risk passing null into str_ends_with	mediawiki/core	master	+1 -1
Handle missing 'wiki' parameter	mediawiki/extensions/SecurePoll	master	+12 -10

Customize query in gerrit

Related Objects
Search...

Status	Subtype	Assigned	Task
Open		None	T396302 Remove old symfony/polyfill-php* replace directives
Stalled		None	T396296 Upgrade symfony/* to PHP 8.1 versions
Resolved		Reedy	T373753 Drop symfony/polyfill-php 73-81 from mediawiki-vendor
Stalled		None	T255792 Quibble runs core:unit tests twice!
Open		None	T376276 PHP 8.4: Implicitly nullable parameter declarations deprecated
Open		None	T379587 PHP 8.4: Implicitly nullable parameter declarations deprecated in 3rd party vendor libs
Open		Reedy	T378424 PHP 8.4: Implicitly nullable parameter declarations deprecated in qrcode vendor libs
Open		None	T358666 Drop PHP 8.1 support from MediaWiki
Open		None	T380185 Prepare for newer geoip2/geoip2 library
Open		None	T338103 Micro-optimize ApiResult::isMetadataKey with str_starts_with once we support PHP8+
Resolved		seanleong-WMDE	T379930 Use WeakMap instead of an array in RestrictedEntityLookupFactory
Stalled		None	T334726 Use return type `never` in Wikibase
Open		None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Resolved		Lucas_Werkmeister_WMDE	T328741 Test failures under PHPUnit 9.6: "Expecting E_DEPRECATED and E_USER_DEPRECATED is deprecated and will no longer be possible in PHPUnit 10"
Resolved		Daimona	T342110 Upgrade to PHPUnit 9.6
Resolved		Daimona	T342259 Move MediaWikiIntegrationTestCase setup and teardown away from run()
Resolved		Daimona	T342301 Remove MediaWikiIntegrationTestCase::$tablesUsed in favour of automatic query tracking
Open		None	T332865 PHPUnit data providers should be simple static functions that return plain data
Resolved		Umherirrender	T337130 Make PHPUnit dataProvider LexemeFieldTestBase::getTestData static (WikibaseLexemeCirrusSearch extension)
Open		None	T337135 Make PHPUnit dataProvider on UstringLibraryTest and LuaEngineUnitTestBase static
Resolved		Umherirrender	T337144 Make PHPUnit dataProvider static in AbuseFilter tests
Resolved		Umherirrender	T337155 Make PHPUnit dataProvider static in ReadingLists tests
Resolved		mszabo	T337156 Make PHPUnit dataProvider static in IPInfo tests
Resolved		tstarling	T337157 Make PHPUnit dataProvider static in LoginNotify tests
Resolved		Umherirrender	T337158 Make PHPUnit dataProvider static in Flow tests
Resolved		Dreamy_Jazz	T337159 Make PHPUnit dataProvider static in CheckUser tests
Resolved		Dreamy_Jazz	T346044 Remove CheckUserUnionQueryBuilder
Resolved		Physikerwelt	T337160 Make PHPUnit dataProvider static in Math tests
Resolved		Tgr	T337161 Make PHPUnit dataProvider static in OAuth tests
Resolved		Umherirrender	T337162 Make PHPUnit dataProvider static in ProofreadPage tests
Resolved		Umherirrender	T337163 Make PHPUnit dataProvider static in CirrusSearch tests
Resolved		None	T337164 Make PHPUnit dataProvider static in FileImporter tests
Resolved		Umherirrender	T337165 Make PHPUnit dataProvider static in GrowthExperiments tests
Resolved		None	T337166 Make PHPUnit dataProvider static in CampaignEvents tests
Resolved		None	T371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
Resolved		karapayneWMDE	T337154 Make PHPUnit dataProvider static in Wikibase tests
Resolved		AudreyPenven_WMDE	T380604 Make provideLuaData static
Resolved		AudreyPenven_WMDE	T380605 Make EntityMetaTagsCreatorTestCase's provideTestGetMetaTags dataProvider static
Resolved		Lucas_Werkmeister_WMDE	T337153 Make PHPUnit dataProvider static in WikibaseQualityConstraints tests
Resolved		Lucas_Werkmeister_WMDE	T337151 Make PHPUnit dataProvider static in WikibaseLexeme tests
Resolved		Umherirrender	T337152 Make PHPUnit dataProvider static in WikibaseMediaInfo tests
Resolved		thiemowmde	T337150 Make PHPUnit dataProvider static in Wikidata.org tests
Resolved		Lucas_Werkmeister_WMDE	T337148 Make PHPUnit dataProvider static in WikibaseCirrusSearch tests
Resolved		Umherirrender	T393065 Make PHPUnit dataProvider on ExtensionJsonTestBase static
Resolved		Umherirrender	T393079 Make PHPUnit dataProvider static in CommunityConfiguration tests
Resolved		Umherirrender	T393080 Make PHPUnit dataProvider static in AutoModerator tests
Resolved		Umherirrender	T393081 Make PHPUnit dataProvider on AbstractChangesListSpecialPageTestCase static
Resolved		Umherirrender	T393082 Make PHPUnit dataProvider on OutputTransformStageTestBase static
Resolved		Umherirrender	T393084 Make PHPUnit dataProvider on TypeDefTestCaseTrait static
Resolved		mszabo	T393115 Make PHPUnit dataProvider on PasswordTestCase static
Resolved		xSavitar	T393122 Make PHPUnit dataProvider on BundleSizeTestBase static
Resolved		Umherirrender	T393132 Make PHPUnit dataProvider on RevisionRecordTests static
Resolved		Umherirrender	T393207 Make PHPUnit dataProvider on ExtensionServicesTestBase static
Resolved		Umherirrender	T393219 Make PHPUnit dataProvider on RestStructureTest static
Open		None	T345481 Migrate Parser and extension tests away from deprecated PHPUnit TestSuite subclassing
Open		None	T358394 Stop using PHPUnit's TestSuite in Scribunto
Open		DannyS712	T363064 MediaWiki.Commenting.MissingCovers.MissingCovers does not support PHPUnit 10.x attributes
Open		None	T363641 IPUtils: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
Resolved		larissagaulia	T363650 Minify: Expecting E_WARNING and E_USER_WARNING is deprecated and will no longer be possible in PHPUnit 10
Open		None	T362858 equivset: Expecting E_ERROR and E_USER_ERROR is deprecated
Open		None	T395743 Use of package ockcyp/covers-validator in libaries is not compatible with PHPUnit 10
In Progress		Jdforrester-WMF	T319055 Upgrade to psr/container 2.x
Resolved		Jdforrester-WMF	T328921 Drop PHP 7.4 and PHP 8.0 support from MediaWiki
In Progress		Krinkle	T319432 Migrate WMF production from PHP 7.4 to PHP 8.1
In Progress		None	T379874 ☂ PHP 8.1 issues found during WMF rollout/ramp up
Resolved	PRODUCTION ERROR	Jdforrester-WMF	T391871 PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecated

Event Timeline

Reedy created this task.Apr 14 2025, 5:19 PM

Restricted Application added a project: Trust and Safety Product Team. · View Herald TranscriptApr 14 2025, 5:19 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Reedy added a parent task: T379874: ☂ PHP 8.1 issues found during WMF rollout/ramp up.Apr 14 2025, 5:19 PM

Reedy added a project: PHP 8.1 support.Apr 14 2025, 5:23 PM

Reedy moved this task from Backlog to MediaWiki core on the PHP 8.1 support board.Apr 14 2025, 5:25 PM

Reedy moved this task from Untriaged to Apr-Jun 2025 on the Wikimedia-production-error board.Apr 14 2025, 5:40 PM

Change #1138717 had a related patch set uploaded (by Jforrester; author: Jforrester):

[mediawiki/core@master] SiteConfiguration::siteFromDb: Don't risk passing null into str_ends_with

https://gerrit.wikimedia.org/r/1138717

gerritbot added a project: Patch-For-Review.Apr 24 2025, 11:28 AM

Jdforrester-WMF changed the task status from Open to In Progress.Apr 24 2025, 11:28 AM

Jdforrester-WMF claimed this task.

Change #1138826 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/extensions/SecurePoll@master] Handle missing 'wiki' parameter

https://gerrit.wikimedia.org/r/1138826

Change #1138862 had a related patch set uploaded (by C. Scott Ananian; author: C. Scott Ananian):

[mediawiki/core@master] Deprecate calling public methods of SiteConfig with incorrect typed args

https://gerrit.wikimedia.org/r/1138862

Tchanders added a project: Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)).Apr 25 2025, 8:45 PM

Tchanders moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)) board.

Tchanders added subscribers: STran, mszabo.

Change #1138826 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Handle missing 'wiki' parameter

https://gerrit.wikimedia.org/r/1138826

ReleaseTaggerBot added a project: MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).Apr 28 2025, 3:00 PM

Change #1138717 abandoned by Jforrester:

[mediawiki/core@master] SiteConfiguration::siteFromDb: Don't risk passing null into str_ends_with

Reason:

Let's go with I8df48a00e1b5c043bed95efdeab42ed99a5b98da.

https://gerrit.wikimedia.org/r/1138717

Change #1138862 merged by jenkins-bot:

[mediawiki/core@master] Deprecate calling public methods of SiteConfiguration with incorrect typed args

https://gerrit.wikimedia.org/r/1138862

Maintenance_bot removed a project: Patch-For-Review.May 2 2025, 8:30 AM

ReleaseTaggerBot edited projects, added MW-1.44-notes (1.44.0-wmf.28; 2025-05-06); removed MW-1.44-notes (1.44.0-wmf.27; 2025-04-29).May 2 2025, 9:00 AM

kostajh edited projects, added Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)); removed Trust and Safety Product Sprint (Sprint Cozonac (April 14 - May 2)).May 5 2025, 6:49 AM

kostajh moved this task from Priority Backlog to Needs Review on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.

Is this done?

mszabo closed this task as Resolved.May 6 2025, 8:49 PM

mszabo moved this task from Needs Review to Done on the Trust and Safety Product Sprint (Sprint Key Lime Pie (May 5 - May 23)) board.

PHP Deprecated: str_ends_with(): Passing null to parameter #1 ($haystack) of type string is deprecatedClosed, ResolvedPublicPRODUCTION ERRORActions