Page MenuHomePhabricator
Create Task
Maniphest T393065

Make PHPUnit dataProvider on ExtensionJsonTestBase static
Closed, ResolvedPublic
Actions

Description

The @dataProvider annotation should be a static function, make

  • ExtensionJsonTestBase::provideHookHandlerNames
  • ExtensionJsonTestBase::provideContentModelIDs
  • ExtensionJsonTestBase::provideApiModuleNames
  • ExtensionJsonTestBase::provideApiQueryModuleListsAndNames
  • ExtensionJsonTestBase::provideSpecialPageNames
  • ExtensionJsonTestBase::provideAuthenticationProviders
  • ExtensionJsonTestBase::provideSessionProviders
  • ExtensionJsonTestBase::provideServicesLists

static and adjust the usages (More infos at T332865).

Needs some compatibility code as some other extensions sub class the abstract class.

Details

Show related patches Customize query in gerrit

Related Objects
Search...

Event Timeline

Umherirrender created this task.Apr 30 2025, 10:56 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptApr 30 2025, 10:56 PM
Umherirrender added a parent task: T332865: PHPUnit data providers should be simple static functions that return plain data.Apr 30 2025, 10:56 PM
Daimona subscribed.Apr 30 2025, 11:26 PM

I briefly looked into this at some point. My rough idea was to remove the need for subclasses to override the data providers, and instead provide better ways to achieve the desired behaviour: all existing overrides are for provideHookHandlerNames to skip hooks from other extensions. There could be a separate static getter to provide those.

Umherirrender added a comment.May 1 2025, 4:32 AM
In T393065#10782441, @Daimona wrote:

I briefly looked into this at some point. My rough idea was to remove the need for subclasses to override the data providers, and instead provide better ways to achieve the desired behaviour: all existing overrides are for provideHookHandlerNames to skip hooks from other extensions. There could be a separate static getter to provide those.

For the override exists T347639: Research a way for the ExtensionJsonTestBase tests to autodetect missing extension and skip the HookHandlers validation in this case
Maybe both tasks should or must fixed together

Umherirrender claimed this task.May 9 2025, 8:25 PM
gerritbot added a comment.May 9 2025, 8:26 PM

Change #1143892 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Make PHPUnit data provider static in ExtensionJsonTestBase

https://gerrit.wikimedia.org/r/1143892

gerritbot added a project: Patch-For-Review.May 9 2025, 8:26 PM
gerritbot added a comment.May 9 2025, 8:29 PM

Change #1143893 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AbuseFilter@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1143893

gerritbot added a comment.May 14 2025, 9:19 AM

Change #1143892 merged by jenkins-bot:

[mediawiki/core@master] tests: Make PHPUnit data provider static in ExtensionJsonTestBase

https://gerrit.wikimedia.org/r/1143892

gerritbot added a comment.May 14 2025, 9:37 AM

Change #1143893 merged by jenkins-bot:

[mediawiki/extensions/AbuseFilter@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1143893

ReleaseTaggerBot added a project: MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 14 2025, 10:00 AM
Maintenance_bot removed a project: Patch-For-Review.May 14 2025, 10:30 AM
gerritbot added a comment.May 14 2025, 7:55 PM

Change #1146045 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/AutoModerator@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146045

gerritbot added a project: Patch-For-Review.May 14 2025, 7:55 PM

Change #1146046 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CampaignEvents@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146046

gerritbot added a comment.May 14 2025, 7:56 PM

Change #1146047 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CentralAuth@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146047

gerritbot added a comment.May 14 2025, 7:56 PM

Change #1146048 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CheckUser@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146048

gerritbot added a comment.May 14 2025, 7:57 PM

Change #1146049 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/CommunityConfiguration@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146049

gerritbot added a comment.May 14 2025, 7:57 PM

Change #1146050 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/EntitySchema@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146050

gerritbot added a comment.May 14 2025, 7:57 PM

Change #1146052 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/RealMe@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146052

gerritbot added a comment.May 14 2025, 7:58 PM

Change #1146053 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146053

gerritbot added a comment.May 14 2025, 7:58 PM

Change #1146054 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseQualityConstraints@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146054

gerritbot added a comment.May 14 2025, 7:58 PM

Change #1146055 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikimediaCampaignEvents@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146055

gerritbot added a comment.May 14 2025, 10:02 PM

Change #1146052 merged by jenkins-bot:

[mediawiki/extensions/RealMe@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146052

Umherirrender mentioned this in rERAM3bac16555767: tests: Make class property static in ExtensionJsonTest.May 14 2025, 10:03 PM
gerritbot added a comment.May 14 2025, 10:13 PM

Change #1146049 merged by jenkins-bot:

[mediawiki/extensions/CommunityConfiguration@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146049

Umherirrender mentioned this in rECOM9963d41ee131: tests: Make class property static in ExtensionJsonTest.May 14 2025, 10:15 PM
gerritbot added a comment.May 14 2025, 10:16 PM

Change #1146048 merged by jenkins-bot:

[mediawiki/extensions/CheckUser@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146048

gerritbot added a comment.May 14 2025, 10:22 PM

Change #1146045 merged by jenkins-bot:

[mediawiki/extensions/AutoModerator@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146045

Umherirrender mentioned this in rEAMO3a7ba25b0540: tests: Make class property static in ExtensionJsonTest.May 14 2025, 10:22 PM
gerritbot added a comment.May 14 2025, 11:00 PM

Change #1146047 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146047

gerritbot added a comment.May 15 2025, 11:07 AM

Change #1146050 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146050

gerritbot added a comment.May 15 2025, 11:07 AM

Change #1146054 merged by jenkins-bot:

[mediawiki/extensions/WikibaseQualityConstraints@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146054

gerritbot added a comment.May 15 2025, 11:07 AM

Change #1146055 merged by jenkins-bot:

[mediawiki/extensions/WikimediaCampaignEvents@master] tests: Make class property static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146055

Umherirrender mentioned this in rEWCE412d6ead6cdd: tests: Make class property static in ExtensionJsonTest.May 15 2025, 11:09 AM
gerritbot added a comment.May 15 2025, 4:34 PM

Change #1146046 merged by jenkins-bot:

[mediawiki/extensions/CampaignEvents@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146046

gerritbot added a comment.May 22 2025, 7:00 PM

Change #1146053 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1146053

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.3; 2025-05-27); removed MW-1.45-notes (1.45.0-wmf.2; 2025-05-20).May 22 2025, 7:00 PM
Maintenance_bot removed a project: Patch-For-Review.May 22 2025, 7:30 PM
Umherirrender closed this task as Resolved.May 22 2025, 8:42 PM
gerritbot added a comment.May 27 2025, 7:13 PM

Change #1151296 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] tests: Remove non-static fallback in ExtensionJsonTestBase

https://gerrit.wikimedia.org/r/1151296

gerritbot added a project: Patch-For-Review.May 27 2025, 7:13 PM
gerritbot added a comment.May 27 2025, 7:44 PM

Change #1151305 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/Wikibase@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1151305

gerritbot added a comment.May 28 2025, 10:52 AM

Change #1151305 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] tests: Make PHPUnit data provider static in ExtensionJsonTest

https://gerrit.wikimedia.org/r/1151305

ReleaseTaggerBot edited projects, added MW-1.45-notes (1.45.0-wmf.4; 2025-06-03); removed MW-1.45-notes (1.45.0-wmf.3; 2025-05-27).May 28 2025, 11:00 AM
gerritbot added a comment.May 29 2025, 4:33 PM

Change #1151296 merged by jenkins-bot:

[mediawiki/core@master] tests: Remove non-static fallback in ExtensionJsonTestBase

https://gerrit.wikimedia.org/r/1151296

Maintenance_bot removed a project: Patch-For-Review.May 29 2025, 5:30 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits