Make PHPUnit dataProvider static in WikibaseMediaInfo tests
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Umherirrender
	May 20 2023, 9:21 PM

Description

The @dataProvider annotation should be a static function, check and make data provider in the extension, at least:

static and adjust the usages (More infos at T332865).

	Subject	Repo	Branch	Lines +/-
	tests: Make PHPUnit data provider static	mediawiki/extensions/WikibaseMediaInfo	master	+21 -23

Status	Assigned	Task
Stalled	None	T255792 Quibble runs core:unit tests twice!
Stalled	None	T334726 Use return type `never` in Wikibase
Open	None	T328919 Upgrade PHPUnit in MediaWiki code to PHPUnit 10
Open	None	T225730 Reduce runtime of MW shared gate Jenkins jobs to 5 min
Open	None	T332865 PHPUnit data providers should be simple static functions that return plain data
Resolved	None	T371467 [GENERAL] Make PHPUnit dataProvider static in Wikibase-related extensions
Resolved	Umherirrender	T337152 Make PHPUnit dataProvider static in WikibaseMediaInfo tests

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

Change #1142666 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/extensions/WikibaseMediaInfo@master] tests: Make PHPUnit data provider static

Change #1142666 merged by jenkins-bot:

[mediawiki/extensions/WikibaseMediaInfo@master] tests: Make PHPUnit data provider static