[Validator] added reviewed Latvian translations #53505
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
k0d3r1s
commented
Jan 11, 2024
k0d3r1s
commented
| Q | A |
|---|---|
| Branch? | 5.4 |
| Bug fix? | yes |
| New feature? | no |
| Deprecations? | no |
| License | MIT |
| @@ -136,7 +136,7 @@ | |||
| </trans-unit> | |||
| <trans-unit id="37"> | |||
| <source>This is not a valid IP address.</source> | |||
| <target state="needs-review-translation">Šī vērtība nav derīga IP adrese.</target> | |||
| <target>Šī nav derīga IP adrese.</target> | |||
There was a problem hiding this comment.
you're removing vērtība but we want the translation to be as if the english version where "This value is not a valid IP address." (same for other updates). Should we keep the word?
There was a problem hiding this comment.
Or use Šai vērtībai as in other existing messages that start with "This value is not"?
There was a problem hiding this comment.
but source part now does not contain word "value". "vērtība" literally means "value"
There was a problem hiding this comment.
yes, that's exactly what I mean.
See #53507
nicolas-grekas
added a commit
that referenced
this pull request
Jan 23, 2024
…ffers from its resource name (nicolas-grekas) This PR was merged into the 5.4 branch. Discussion ---------- [Validator] Make it explicit when English translation differs from its resource name | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | no | New feature? | no | Deprecations? | no | Issues | - | License | MIT Inspired by #53505 Follows #53420 Commits ------- eaedae6 [Validator] Make it explicit when English translation differs from its resource name
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.