Skip to content

[Validator] Make it explicit when English translation differs from its resource name #53507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 23, 2024

Conversation

nicolas-grekas
Copy link
Member

@nicolas-grekas nicolas-grekas commented Jan 11, 2024

Q A
Branch? 5.4
Bug fix? no
New feature? no
Deprecations? no
Issues -
License MIT

Inspired by #53505
Follows #53420

@k0d3r1s
Copy link
Contributor

k0d3r1s commented Jan 11, 2024

i kinda don't get this one. isn't target supposed to be somewhat exact translation of source?
why only english can differ in this regard? doesn't this make it somewhat harder to maintain?
also, regarding #53505, for example the one with ip address translation - source is "This value is not valid ...", rename part is "This is not valid ...". What does latvian part be? With or without "value"?
Technically with as target is directly translating source? Or latvian part may differ from source, as "value" part is as unnecessary part of that sentence as it is in english?

@nicolas-grekas
Copy link
Member Author

@k0d3r1s you might want to check #53420, that should answer your concern.

@k0d3r1s
Copy link
Contributor

k0d3r1s commented Jan 11, 2024

@nicolas-grekas ok, read through it. now i just feel that this needs to be documented somewhere (probably in docs). as now that message in code differs from translation key, it is harder to find why.
but again then, why is it not consistent? unit 37 (ip address one) has this new rename but unit 38, for example, does not

@nicolas-grekas
Copy link
Member Author

nicolas-grekas commented Jan 11, 2024

Unit 38 already starts with "This value is not" so I just aligned unit 37. This can be documented for sure, that's what I'm trying to do here, just with a technical PoV. Docs improvement would be nice indeed! Help wanted :)
Why isn't this consistent at the source level? History 🤷‍♂️ And it's hard to remember when reviewing new messages (but we should still be more careful.)

@stof
Copy link
Member

stof commented Jan 11, 2024

Shouldn't this be implemented by .github/sync-translations.php to ensure this is kept uptodate as well ?

The current typos (which are not done for all keys) tell me that this was done manually.

@nicolas-grekas
Copy link
Member Author

Shouldn't this be implemented by .github/sync-translations.php to ensure this is kept uptodate as well ?

yes! script updated.

Status: needs review

@nicolas-grekas nicolas-grekas merged commit db2c6e4 into symfony:5.4 Jan 23, 2024
@nicolas-grekas nicolas-grekas deleted the resname branch January 23, 2024 09:05
nicolas-grekas added a commit that referenced this pull request Jan 23, 2024
This PR was merged into the 5.4 branch.

Discussion
----------

[Validator] revise Latvian translations

| Q             | A
| ------------- | ---
| Branch?       | 5.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

Latvian translation revisions after #53507

Commits
-------

4ce1384 [Validator] revise Latvian translations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants