-
-
Notifications
You must be signed in to change notification settings - Fork 9.7k
[Validator] Make it explicit when English translation differs from its resource name #53507
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
i kinda don't get this one. isn't target supposed to be somewhat exact translation of source? |
8407f78
to
7a9bf76
Compare
@nicolas-grekas ok, read through it. now i just feel that this needs to be documented somewhere (probably in docs). as now that message in code differs from translation key, it is harder to find why. |
Unit 38 already starts with "This value is not" so I just aligned unit 37. This can be documented for sure, that's what I'm trying to do here, just with a technical PoV. Docs improvement would be nice indeed! Help wanted :) |
src/Symfony/Component/Validator/Resources/translations/validators.af.xlf
Outdated
Show resolved
Hide resolved
Shouldn't this be implemented by The current typos (which are not done for all keys) tell me that this was done manually. |
7a9bf76
to
eaedae6
Compare
yes! script updated. Status: needs review |
This PR was merged into the 5.4 branch. Discussion ---------- [Validator] revise Latvian translations | Q | A | ------------- | --- | Branch? | 5.4 | Bug fix? | yes | New feature? | no | Deprecations? | no | License | MIT Latvian translation revisions after #53507 Commits ------- 4ce1384 [Validator] revise Latvian translations
Inspired by #53505
Follows #53420