[Form] [Hackday] [2.7] Deprecate PRE_BIND, BIND and POST_BIND form events #12648
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
neoshadybeat
commented
Nov 29, 2014
neoshadybeat
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | yes |
| Tests pass? | yes |
| Fixed tickets | #12648 |
| License | MIT |
| Doc PR | none |
| } elseif ($eventName === FormEvents::BIND) { | ||
| trigger_error('Event BIND is deprecated since Symfony 2.3. Use SUBMIT instead', E_USER_DEPRECATED); | ||
| } elseif ($eventName === FormEvents::POST_BIND) { | ||
| trigger_error('Event POST_SUBMIT is deprecated since Symfony 2.3. Use POST_SUBMIT instead', E_USER_DEPRECATED); |
There was a problem hiding this comment.
The first POST_SUBMIT should be POST_BIND.
|
@xabbuh thanks, I'll change It |
neoshadybeat
changed the title
| @@ -207,6 +207,8 @@ public function __construct($name, $dataClass, EventDispatcherInterface $dispatc | |||
| */ | |||
| public function addEventListener($eventName, $listener, $priority = 0) | |||
| { | |||
| $this->checkIfEventNameIsDeprecated($eventName); | |||
There was a problem hiding this comment.
please inline, no private
neoshadybeat
force-pushed
the
2.7
branch
2 times, most recently
from
f2773b5 to
927b526
Compare
|
This is broken, because the new constants have the same values than the deprecated ones, so you will always trigger the deprecation warning here. 👎 |
|
good catch @stof it's broken. 👎 |
Merged
|
Closing: by using PHP lazy loading of constants values, #12968 adds specific enough deprecation notices. |
fabpot
added a commit
that referenced
this pull request
Dec 20, 2014
…cmorales) This PR was merged into the 2.7 branch. Discussion ---------- Deprecations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12625, #12605, #12628, #12622, #12642, #12609, #12651, #12604, #12607, #12667, #12648 | License | MIT | Doc PR | - Cherry-picking some pending PRs to make them move forward Commits ------- badf8fc [Form] Log deprecation of constants, fixes #12607 #12667 1d58df4 Fix deprecation notice on VirtualFormAwareIterator e2a19ee Add a deprecation note about VirtualFormAwareIterator ab4d9b8 Add a deprecation note about CsrfProviderInterface cb70632 [HttpKernel] fix deprecation notice for Kernel::init() b5a315d [HttpKernel] Added deprecated error to init() 70012c1 [Hackday] [2.7] Add a deprecation note about TypeTestCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.