[Hackday] [2.7] Add a deprecation note about TypeTestCase #12605 #12625
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jzawadzki
commented
Nov 29, 2014
jzawadzki
commented
| Q | A |
|---|---|
| Fixed tickets | #12605 |
| License | MIT |
| @@ -18,4 +18,8 @@ | |||
| */ | |||
| abstract class TypeTestCase extends BaseTypeTestCase | |||
| { | |||
| protected function setUp() | |||
| { | |||
| trigger_error('Abstract class "Symfony\Component\Form\Tests\TypeTestCase" is deprecated since version 2.3 and will be removed in 3.0. Use "Symfony\Component\Form\Test\TypeTestCase" instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
You should call parent::setUp();
There was a problem hiding this comment.
@nicolas-grekas - is this really needed? as this is test phpunit will catch this trigger.
so it shouldn't matter that this won't work?
There was a problem hiding this comment.
@jzawadzki I think it should be possible to execute tests nonetheless when ignoring the deprecation warnings in PHPUnit which won't work without the setUp() call.
There was a problem hiding this comment.
@xabbuh @nicolas-grekas ok, you're right - added
Merged
|
Cherry-picked in #12968, thanks |
fabpot
added a commit
that referenced
this pull request
Dec 20, 2014
…cmorales) This PR was merged into the 2.7 branch. Discussion ---------- Deprecations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12625, #12605, #12628, #12622, #12642, #12609, #12651, #12604, #12607, #12667, #12648 | License | MIT | Doc PR | - Cherry-picking some pending PRs to make them move forward Commits ------- badf8fc [Form] Log deprecation of constants, fixes #12607 #12667 1d58df4 Fix deprecation notice on VirtualFormAwareIterator e2a19ee Add a deprecation note about VirtualFormAwareIterator ab4d9b8 Add a deprecation note about CsrfProviderInterface cb70632 [HttpKernel] fix deprecation notice for Kernel::init() b5a315d [HttpKernel] Added deprecated error to init() 70012c1 [Hackday] [2.7] Add a deprecation note about TypeTestCase
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.