Added deprecated error to init() #12628
Conversation
dkvk
commented
Nov 29, 2014
dkvk
commented
| Q | A |
|---|---|
| Fixed tickets | [#12622] |
| License | MIT |
| @@ -93,6 +93,7 @@ public function __construct($environment, $debug) | |||
| */ | |||
| public function init() | |||
| { | |||
| trigger_error('This method is going to be removed in 3.0', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Can you be more explicit please? You should take the full original deprecation message, but tell the name of the method ("This" needs context, but there is none for the reader)
|
Updated error message with same message as in the annotation. |
| @@ -93,6 +93,7 @@ public function __construct($environment, $debug) | |||
| */ | |||
| public function init() | |||
| { | |||
| trigger_error('Deprecated since version 2.3, to be removed in 3.0. Move your logic in the constructor instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
Should be "The Kernel::init() method was deprecated in version 2.3 and will be removed in 3.0. ..."
|
Message has been updated to comply with the format @fabpot point out |
| @@ -93,6 +93,7 @@ public function __construct($environment, $debug) | |||
| */ | |||
| public function init() | |||
| { | |||
| trigger_error('The Kernel::init() method was deprecated in version 2.3 and will be removed in 3.0. Move your logic to the constructor instead.', E_USER_DEPRECATED); | |||
There was a problem hiding this comment.
That won't work as the init() method is called in the __construct method above, so the warning will always be displayed.
|
But if we remove the init() from __construct() we will introduce a break? |
|
The issue is that we would need to trigger a deprecation notice in case the method is overwritten. Your deprecation notice is triggered only when it is wrong |
|
In the constructor, you need to do some reflection on |
|
Cherry-picked in #12968, thanks |
…cmorales) This PR was merged into the 2.7 branch. Discussion ---------- Deprecations | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #12625, #12605, #12628, #12622, #12642, #12609, #12651, #12604, #12607, #12667, #12648 | License | MIT | Doc PR | - Cherry-picking some pending PRs to make them move forward Commits ------- badf8fc [Form] Log deprecation of constants, fixes #12607 #12667 1d58df4 Fix deprecation notice on VirtualFormAwareIterator e2a19ee Add a deprecation note about VirtualFormAwareIterator ab4d9b8 Add a deprecation note about CsrfProviderInterface cb70632 [HttpKernel] fix deprecation notice for Kernel::init() b5a315d [HttpKernel] Added deprecated error to init() 70012c1 [Hackday] [2.7] Add a deprecation note about TypeTestCase
