Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: coder/coder-desktop-macos
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 6082e2d
Choose a base ref
...
head repository: coder/coder-desktop-macos
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d5bc158
Choose a head ref
  • 7 commits
  • 13 files changed
  • 1 contributor

Commits on Jun 26, 2025

  1. chore: append bundle version to mach service name (#191)

    We append the CFBundleVersion to the service name to ensure a new service is used for each version. This works around the issue described in #121, presumably caused by the XPC service cache not being invalidated on update.
    
    ![image](https://github.com/user-attachments/assets/5b1f2d1d-7aa1-4f58-92b0-ecee712f9131)
    ethanndickson authored Jun 26, 2025
    Configuration menu
    Copy the full SHA
    c19b39a View commit details
    Browse the repository at this point in the history

Commits on Jul 9, 2025

  1. fix: correct remote file picker dropdown chevron alignment (#192)

    There appears to be a bug when a View created using `NSView` is inside a `DisclosureGroup` label - regardless of the size of the `NSView`, it breaks the alignment of the chevron that's included on the DisclosureGroup label by default:
    ![](https://github.com/user-attachments/assets/d6a14a29-1b79-4a82-ac9f-62cf88142140)
    
    In #184 we added an `NSView` to the spinner, causing this issue. 
    
    This is almost certainly a SwiftUI bug, and so we'll work around it by placing the spinner and error symbol to the right of the label by just setting a trailing padding on the text.
    The end result (with spinners on):
    ![](https://github.com/user-attachments/assets/50a7a7d3-bc68-4e02-b023-505b05759bf9)
    ethanndickson authored Jul 9, 2025
    Configuration menu
    Copy the full SHA
    15f1890 View commit details
    Browse the repository at this point in the history

Commits on Jul 10, 2025

  1. fix: allow creating directories in file sync local file picker (#199)

    Closes #198.
    
    I just assumed this was on by default 😭
    
    In fact, the documentation says it is, but it's very clearly not!
    ```
    /**
     `NSSavePanel`/`NSOpenPanel`: Set to `YES` to show the "New Folder" button. Default is `YES`.
     */
    open var canCreateDirectories: Bool
    ```
    ethanndickson authored Jul 10, 2025
    Configuration menu
    Copy the full SHA
    ff0bea0 View commit details
    Browse the repository at this point in the history

Commits on Jul 23, 2025

  1. fix: fix panic deleting file sync session via right click (#202)

    Also configures the linter to pick up on unused arguments, and configures the formatter to not format them out (by setting them to _). If this was the case prior, this bug wouldn't have happened.
    ethanndickson authored Jul 23, 2025
    Configuration menu
    Copy the full SHA
    ebcb698 View commit details
    Browse the repository at this point in the history

Commits on Jul 24, 2025

  1. fix: prompt for sign in when toggling coder connect on (#204)

    I undid the work of #114 in #158, by disabling the VPN toggle when the network extension was unconfigured.
    When signed out, the network extension is unconfigured.
    This PR adds a special exception to make the VPN toggle always clickable when signed out, as it has special behaviour when signed out.
    It also adds a proper regression test. A slightly different regression test existed, but it didn't account for cases where the VPN state is one that would normally disable the toggle.
    ethanndickson authored Jul 24, 2025
    Configuration menu
    Copy the full SHA
    faaa0af View commit details
    Browse the repository at this point in the history
  2. fix: trim whitespace and newlines from access url and token textfields (

    #207)
    
    Prevents scenarios like the following, where newlines are pasted in by accident:
    
    <img width="555" height="246" alt="image" src="https://github.com/user-attachments/assets/5f473dd4-dc11-4a28-a3b2-9e7bc57d033f" />
    
    The Windows app has trimming in the same places.
    ethanndickson authored Jul 24, 2025
    Configuration menu
    Copy the full SHA
    5da2698 View commit details
    Browse the repository at this point in the history
  3. feat: make workspaces list scrollable on overflow (#197)

    Closes #188.
    
    If the workspaces view exceeds 400px in height, it'll become scrollable. The diff without whitespace changes is like 4 lines.
    
    https://github.com/user-attachments/assets/5bdd0369-c882-4085-9513-7594bd100475
    
    
    I think the `View more`/`View less` very much still makes sense, so I'm keeping it.
    ethanndickson authored Jul 24, 2025
    Configuration menu
    Copy the full SHA
    d5bc158 View commit details
    Browse the repository at this point in the history
Loading