chore: prompt for sign in when turning VPN on if signed out #114
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ethanndickson
commented
Mar 19, 2025
| @@ -23,7 +23,7 @@ struct VPNMenuTests { | |||
| try await ViewHosting.host(view) { | |||
| try await sut.inspection.inspect { view in | |||
| let toggle = try view.find(ViewType.Toggle.self) | |||
| #expect(toggle.isDisabled()) | |||
| #expect(!toggle.isDisabled()) | |||
There was a problem hiding this comment.
The toggle is now enabled when signed out.
deansheather
approved these changes
Mar 19, 2025
ThomasK33
approved these changes
Mar 19, 2025
ethanndickson
changed the base branch from
ethan/only-start-when-ready
to
graphite-base/114
ethanndickson
force-pushed
the
ethan/toggle-prompt-sign-in
branch
from
830002a to
982a23f
Compare
ethanndickson
added a commit
that referenced
this pull request
Jul 24, 2025
I undid the work of #114 in #158, by disabling the VPN toggle when the network extension was unconfigured. When signed out, the network extension is unconfigured. This PR adds a special exception to make the VPN toggle always clickable when signed out, as it has special behaviour when signed out. It also adds a proper regression test. A slightly different regression test existed, but it didn't account for cases where the VPN state is one that would normally disable the toggle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #106.