fix: fix panic deleting file sync session via right click (#202)

ethanndickson · web-flow · commit ebcb6988591d · 2025-07-23T12:03:28.000+10:00
Also configures the linter to pick up on unused arguments, and configures the formatter to not format them out (by setting them to _). If this was the case prior, this bug wouldn't have happened.
diff --git a/Coder-Desktop/.swiftformat b/Coder-Desktop/.swiftformat
@@ -1,3 +1,4 @@
 --selfrequired log,info,error,debug,critical,fault
 --exclude **.pb.swift,**.grpc.swift
---condassignment always
+--condassignment always
+--disable unusedArguments
diff --git a/Coder-Desktop/.swiftlint.yml b/Coder-Desktop/.swiftlint.yml
@@ -3,6 +3,8 @@ disabled_rules:
   - trailing_comma
   - blanket_disable_command # Used by Protobuf
   - opening_brace # Handled by SwiftFormat
+opt_in_rules:
+  - unused_parameter
 type_name:
   allowed_symbols: "_"
 identifier_name:
diff --git a/Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift b/Coder-Desktop/Coder-Desktop/Views/FileSync/FileSyncConfig.swift
@@ -165,11 +165,11 @@ struct FileSyncConfig<VPN: VPNService, FS: FileSyncDaemon>: View {
     }
 
     // TODO: Support selecting & deleting multiple sessions at once
-    func delete(session _: FileSyncSession) async {
+    func delete(session: FileSyncSession) async {
         loading = true
         defer { loading = false }
         do throws(DaemonError) {
-            try await fileSync.deleteSessions(ids: [selection!])
+            try await fileSync.deleteSessions(ids: [session.id])
         } catch {
             actionError = error
         }

Original file line number	Diff line number	Diff line change
`@@ -165,11 +165,11 @@ struct FileSyncConfig<VPN: VPNService, FS: FileSyncDaemon>: View {`
`165`	`165`	`}`
`166`	`166`
`167`	`167`	`// TODO: Support selecting & deleting multiple sessions at once`
`168`		`- func delete(session _: FileSyncSession) async {`
	`168`	`+ func delete(session: FileSyncSession) async {`
`169`	`169`	`loading = true`
`170`	`170`	`defer { loading = false }`
`171`	`171`	`do throws(DaemonError) {`
`172`		`- try await fileSync.deleteSessions(ids: [selection!])`
	`172`	`+ try await fileSync.deleteSessions(ids: [session.id])`
`173`	`173`	`} catch {`
`174`	`174`	`actionError = error`
`175`	`175`	`}`