feat(site): support icon and description in preset #19063
+73
−71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssncferreira
changed the title
There was a problem hiding this comment.
Pull Request Overview
This PR updates the workspace creation UI to support icon and description display for presets by replacing the SelectFilter component with the more feature-rich Combobox component.
- Replaces
SelectFilterwithComboboxin the workspace creation form - Updates preset option structure to include icon and description fields
- Modifies
Comboboxto render preset icons usingExternalImageinstead ofAvatar
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| site/src/pages/CreateWorkspacePage/CreateWorkspacePageView.tsx | Replaces SelectFilter with Combobox and updates preset options to include icon/description |
| site/src/components/Combobox/Combobox.tsx | Updates icon rendering to use ExternalImage instead of Avatar |
ssncferreira
commented
Jul 29, 2025
| @@ -103,7 +103,8 @@ export const SearchAndFilter: Story = { | |||
| screen.queryByRole("option", { name: "Kotlin" }), | |||
| ).not.toBeInTheDocument(); | |||
| }); | |||
| await userEvent.click(screen.getByRole("option", { name: "Rust" })); | |||
| // Accessible name includes both image alt text and text content: "Rust Rust" | |||
| await userEvent.click(screen.getByRole("option", { name: "Rust Rust" })); | |||
There was a problem hiding this comment.
Since we changed the icon image to be an ExternalImage with alt={option.displayName} https://github.com/coder/coder/pull/19063/files#diff-f7c0d4d4c43b6dd17458ff44a1a0dfdccfae367b09ffe41fdbe09c48c151e466R126
The name includes both the image alt text (Rust) + the text content (Rust). Let me know if this is ok, or if there is a better way to filter out this element.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the
CreateWorkspacePageViewto use theComboboxReact component instead ofSelectFilterfor the Preset selection.Changes
CreateWorkspacePageViewto use theComboboxcomponent in place ofSelectFilter.Comboboxcomponent to render preset icons usingExternalImageinstead ofAvatar.Follow-up from: #18977