-
Notifications
You must be signed in to change notification settings - Fork 952
feat: add icon and description to preset #18977
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
303e4d1
to
531420f
Compare
ADD COLUMN IF NOT EXISTS description VARCHAR(128) NOT NULL DEFAULT '', | ||
ADD COLUMN IF NOT EXISTS icon VARCHAR(256) NOT NULL DEFAULT ''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Applying the same size constraints as:
67bd572
to
9310007
Compare
9310007
to
24493de
Compare
Description
This PR adds support for
description
andicon
fields totemplate_version_presets
. These fields will allow displaying richer information for presets in the UI, improving the user experience when creating a workspace.Both fields are optional, non-nullable, and default to empty strings.
Changes
description VARCHAR(128)
andicon VARCHAR(256)
columns to thetemplate_version_presets
table.CreateWorkspacePageView
in the UIUI Changes (Work in progress)
Requires: coder/terraform-provider-coder#422 (release: #19032)
Closes: #18111