Skip to content

Add support for TOML renderer #197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
May 14, 2020
Merged

Add support for TOML renderer #197

merged 10 commits into from
May 14, 2020

Conversation

khos2ow
Copy link
Member

@khos2ow khos2ow commented Feb 18, 2020

Prerequisites

Put an x into the box(es) that apply:

  • This pull request fixes a bug.
  • This pull request adds a feature.
  • This pull request enhances existing functionality.
  • This pull request introduces breaking change.

For more information, see the Contributing Guide.

Description

This PR adds support for new TOML renderer.

Issues Resolved

List any existing issues this pull request resolves.

Checklist

Put an x into all boxes that apply:

Tests

  • I have added tests to cover my changes.
  • All tests pass when I run make test.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Code Style

  • My code follows the code style of this project.

@khos2ow khos2ow added this to the v0.9.0 milestone Feb 18, 2020
@khos2ow
Copy link
Member Author

khos2ow commented Feb 18, 2020

This PR is blocked by #195

@ndhoule

This comment has been minimized.

Sign in to view
@codecov-io
Copy link

codecov-io commented Mar 29, 2020 •
edited
Loading

Codecov Report

Merging #197 into master will decrease coverage by 0.91%.
The diff coverage is 92.00%.

@@            Coverage Diff             @@
##           master     #197      +/-   ##
==========================================
- Coverage   81.38%   80.47%   -0.92%     
==========================================
  Files          33       31       -2     
  Lines        1746     1613     -133     
==========================================
- Hits         1421     1298     -123     
+ Misses        272      264       -8     
+ Partials       53       51       -2
Impacted Files Coverage Δ
pkg/tfconf/input.go 83.33% <ø> (ø)
pkg/tfconf/module.go 0.00% <ø> (ø)
pkg/tfconf/output.go 86.66% <ø> (ø)
pkg/tfconf/provider.go 100.00% <ø> (ø)
internal/format/toml.go 92.00% <92.00%> (ø)
internal/module/module.go 90.59% <0.00%> (-0.45%) ⬇️
internal/format/util.go 100.00% <0.00%> (ø)
internal/module/input.go 100.00% <0.00%> (ø)
internal/module/options.go 80.00% <0.00%> (ø)
internal/format/asciidoc_document.go
... and 9 more

@khos2ow khos2ow modified the milestones: v0.9.0, v0.10.0 Mar 31, 2020
@khos2ow khos2ow merged commit 064060e into terraform-docs:master May 14, 2020
@khos2ow khos2ow deleted the toml branch May 14, 2020 16:34
khos2ow added a commit that referenced this pull request May 14, 2020
@khos2ow
feat: Add support for TOML renderer (#197)
b397b7d 
* Add support for TOML renderer

* Add kind:formatter to toml command

* update docs

* adjust tests after merge

* fix after merge

* adjust tests after merge

* update docs

* remove vendor leftovers

* update doc

* update tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cmd/new command cmd/toml document needed format/toml new feature
Projects
None yet
Milestone
v0.10.0
Development

Successfully merging this pull request may close these issues.
3 participants
@khos2ow @ndhoule @codecov-io