Introduce Format interface and expose to public pkg #195
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prerequisites
Put an
x
into the box(es) that apply:For more information, see the Contributing Guide.
Description
A complete overhaul of the
internal/pkg
packages and move the to eitherinternal/
for simplicity and not duplicate pkg namepkg/
to be accessible publicly (as this is a hard requirement for enabling Plugin system)Publicly available packages are:
print
: defines an interface to be implemented by a Formattertfconf
: internal representation of a loaded Terraform Moduletmpl
: templating system which can be used internally or by external plugin developerChange in the
internal
package:print.Format
interface was introduced everything frominternal/pkg/print/...
was moved under a flatinternal/format
package. This newformat
package contains all the different available formats and their corresponding test files andtestdata
golden files.Issues Resolved
#149 is blocked by this.
Checklist
Put an
x
into all boxes that apply:Tests
make test
.Documentation
Code Style