[Console] unmerge application args when needed #9286
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
any news about this? I can see it's hanging there for a while :) |
* 2.3: [ci] Tweak scripts
…class (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle] move test methods to test case class | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? |no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 8188653 move test methods to test case class
This PR was merged into the 2.7 branch. Discussion ---------- [2.7] fix mocking of some methods | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | items 6 and 8 of sebastianbergmann/phpunit-mock-objects#299 (comment) | License | MIT | Doc PR | Commits ------- a45b93d [2.7] fix mocking of some methods
…iltar) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle 2.7+] Removed unused variables | Q | A | ------------- | --- | Branch? | 2.7, can be merged upwards | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | ~ | License | MIT | Doc PR | ~ I noticed some unused variables in the Framework Extension. I did a project inspection in phpstorm and I found nothing else. Hence I submit this PR to make it consistent again. Commits ------- 9fea1ee Removed unused variables
* 2.3: fix mocks Conflicts: src/Symfony/Component/Security/Http/Tests/Firewall/SwitchUserListenerTest.php
This PR was merged into the 2.7 branch. Discussion ---------- [2.7] fix mocks | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | * check for existance of `setMetadataFactory()` method (this is needed for tests run with deps=high as the method was removed in Symfony 3.0) * fix mock testing the `EngineInterface` as the `stream()` method cannot be mocked when it is does not exist in the mocked interface Commits ------- d9be1b4 fix mocks
* 2.3: [Request] Fix support of custom mime types with parameters
released v2.7.11
`ChoiceListFactoryInterface` expected `$group_by` to be a callable or null not an array. The factory defaults `group_by` to `ChoiceListInterface::getStructuredValues`.
This PR was merged into the 2.7 branch. Discussion ---------- [Validator] do not treat payload as callback | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | see http://stackoverflow.com/a/36140305/2289865 Commits ------- 2066fc0 [Validator] do not treat payload as callback
* 2.3: [phpunit] disable prophecy
Request is needed in RouterController::getTraces to be able to create a request.
…amporter) This PR was merged into the 2.7 branch. Discussion ---------- [WebProfilerBundle] Add missing use statement. | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | The RouterController creates a Request in getTraces, but does not have a `use` statement, which causes an exception when trying to view profile routing in >2.7. Commits ------- 0d31c3e [WebProfilerBundle] Add missing use statement.
…xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [FrameworkBundle][TwigBridge] fix high deps tests | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- aa4dd4f fix high deps tests
* 2.3: [ci] Get ICU/intl from github instead of nebm.ist.utl.pt/~glopes [Debug] Fix handling of php7 throwables [Process] remove dead code [ClassLoader] Fix storing not-found classes in APC cache [Form] cs fixes in date types
This PR was merged into the 2.7 branch. Discussion ---------- Php cs fixer | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | n/a | License | MIT | Doc PR | n/a Commits ------- 7cc3ca5 fixed CS fdef804 tweaked default CS fixer config
This PR was merged into the 2.7 branch. Discussion ---------- Avoid phpunit 5.4 warnings on getMock (2.7+) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#19125 | License | MIT | Doc PR | ~ Avoids calling `getMock()` in phpunit 5.4 which will trigger a warning (and thus failing test suite) when used by developers as this TestCase is an extension point. Commits ------- b05014c Avoid phpunit 5.4 warnings on getMock
…ekas) This PR was merged into the 2.7 branch. Discussion ---------- [Process] Fix pipes cleaning on Windows | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#19089 | License | MIT | Doc PR | - Commits ------- d54cd02 [Process] Fix pipes cleaning on Windows
…ue block names (enumag) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Add exception to FormRenderer about non-unique block names | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#17874 | License | MIT | Doc PR | Commits ------- c6db6f3 [Form] Add exception to FormRenderer about non-unique block names
… submitted (egeloen) This PR was merged into the 2.7 branch. Discussion ---------- [Form] Consider a violation even if the form is not submitted | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | yes (only for the behavior) | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11493 | License | MIT | Doc PR | Hey! I'm currently implementing an API using the form component in order to validate the payload sent (in conjonction with the FOSRestBundle). Unfortunatelly, we dig into an issue about the PATCH request which don't map some of our validation rules to the form. Basically, the violations are lost in the middle of the process. ### Use case We have an entity with the following fields "type", "image" & "video". The field "type"can be either "default", "image" or "video" and then accordingly we use the appropriate field (none for the "default" type, video for the "video" type and image for the "image" type. Then, in our form, we change the validation groups according to our entity type in order to make the "image" field mandatory if the type is "image" and the same for the video field if the type is "video". ### Current behavior The current behavior (since 2.5) seems to not propages a violation to a form if this form is not submitted but in our use case, changing the field "type" via a PATCH request triggers some new validation which should be reported to end user (inform that a field (video or image) is missing in the PATCH request). ### Expected behavior The current behavior was introduced in symfony#10567 but IMO, this update is a bug as suggested by @webmozart in symfony#11493 (comment) Instead, the form component should still map validation errors to the form even if the field was not submitted. If the initial data is not valid, then your initial data was buggy from the beginning but the form should not accept it and instead of silently ignoring the errors, end users should be informed and fix it. WDYT? Commits ------- c483a0f [Form] Consider a violation even if the form is not submitted
…trange format (guiled, fabpot) This PR was merged into the 2.7 branch. Discussion ---------- [DomCrawler] No more exception on field name with strange format | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#18569, symfony#18570 | License | MIT | Doc PR | n/a Commits ------- e204913 finished previous commit 953a383 No more exception for malformed input name
…ssing a value closure
…oiceLoader when passing a value closure (webmozart) This PR was merged into the 2.7 branch. Discussion ---------- [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - This PR is porting an optimization done for `loadChoicesForValues()` in 64c80a6 to `loadValuesForChoices()`. Commits ------- f6e5298 [DoctrineBridge] Don't use object IDs in DoctrineChoiceLoader when passing a value closure
…with defaults (sstok) This PR was submitted for the 2.8 branch but it was merged into the 2.7 branch instead (closes symfony#19100). Discussion ---------- [Console] Fixed SymfonyQuestionHelper multi-choice with defaults |Q |A | |--- |---| |Bug Fix? |yes| |New Feature? |no | |BC Breaks? |no | |Deprecations?|no | |Tests Pass? |yes| |Fixed Tickets| | |License |MIT| |Doc PR | | When you use the SymfonyStyle with a multi-choice question and multiple defaults. You get an notice because the key is used as-is `0,1` instead of splitting the value. This pull-request changes the SymfonyQuestionHelper to checks if the Choice is a multi-choice and displays the selected values correctly `[blue, yellow]`. Note: Tests are missing, but both the SymfonyStyle and SymfonyQuestionHelper classes have almost no tests. Making it really hard 😇 hopefully symfony#19097 will make this easier 👍 Commits ------- a8f6f85 Fixed SymfonyQuestionHelper multi-choice with defaults
…2) (David Badura) This PR was merged into the 2.7 branch. Discussion ---------- [FORM] fix post_max_size_message translation (alt. 2) | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#15479, symfony#18543 | License | MIT | Doc PR | - Commits ------- 9d8a5e5 fix post_max_size_message translation
…0 or higher (xabbuh) This PR was merged into the 2.7 branch. Discussion ---------- [Validator] explicitly forbid e-mail validator 2.0 or higher | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 81a6d8e explicitly forbid e-mail validator 2.0 or higher
…p (chalasr) This PR was merged into the 2.7 branch. Discussion ---------- [TwigBridge] Fix inconsistency in LintCommand help | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#19139 (comment) | License | MIT | Doc PR | ~ Actually, the `lint:yaml` command's help looks like this:  The last `Or` about STDIN is syntactically wrong, and is the only one to have a code example with indentation. This gives the same indentation for all code blocks and move the STDIN-related part as first, as proposed in symfony#19139 (comment) . Now it looks like:  Commits ------- f54bb16 [TwigBridge] Fix inconsistency in LintCommand help
This PR was merged into the 2.7 branch. Discussion ---------- sync min email validator version | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | I stumbled upon this while trying to run the min deps version tests while installing everything from the global `composer.json` file. In the Validator component, we already have this present for a long time sine b1b5cca. Commits ------- c484db1 sync min email validator version
…ar displays (rquadling) This PR was merged into the 2.7 branch. Discussion ---------- Distinguish between first and subsequent progress bar displays | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#19133 | License | MIT | Doc PR | reference to the documentation PR, if any Fixes symfony#19133 When a progress bar is first displayed, if it is multi-line, previously output lines are erased, depending upon the number of lines in the progress bar. This patch fixes that be distinguishing between the first display (no erasing of previous output) and subsequent displays of the progress bar. Commits ------- 3871e1a Differentiate between the first time a progress bar is displayed and subsequent times
This PR was merged into the 2.7 branch. Discussion ---------- [Console] removed unneeded private methods | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | https://github.com/symfony/symfony/pull/19134/files/3871e1a95056ce8278e6b86d3e8005836ecab954#r68286709 | License | MIT | Doc PR | n/a Commits ------- 35f32eb [Console] removed unneeded private methods
bamarni
force-pushed
the
command-app-args
branch
from
b4d8808 to
73a4a36
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
License of the code: MIT
A more generic approach solving #9266, I've patched it on 2.3 directly as there as been some refactoring between 2.2 and 2.3 making the fix different for each branch.