Skip to content

[2.7] fix mocking of some methods #18286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 24, 2016
Merged

Conversation

xabbuh
Copy link
Member

@xabbuh xabbuh commented Mar 23, 2016

Q A
Branch? 2.7
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets items 6 and 8 of sebastianbergmann/phpunit-mock-objects#299 (comment)
License MIT
Doc PR

{
}

public function backup($backup)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is the idea behind adding this method? seems arbitrary as it doesn't influence the test.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are right. In case the setBackup() method is not present we cannot do anything else than making sure that the code does not break by trying to call a non-existent method.

@xabbuh xabbuh force-pushed the mocking-fixes-2.7 branch from 1fb3087 to a45b93d Compare March 24, 2016 09:06
@Tobion
Copy link
Contributor

Tobion commented Mar 24, 2016

Thank you @xabbuh.

@Tobion Tobion merged commit a45b93d into symfony:2.7 Mar 24, 2016
Tobion added a commit that referenced this pull request Mar 24, 2016
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] fix mocking of some methods

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | items 6 and 8 of sebastianbergmann/phpunit-mock-objects#299 (comment)
| License       | MIT
| Doc PR        |

Commits
-------

a45b93d [2.7] fix mocking of some methods
@xabbuh xabbuh deleted the mocking-fixes-2.7 branch March 24, 2016 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants