[2.7] fix mocking of some methods #18286
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
xabbuh
commented
Mar 23, 2016
xabbuh
commented
| Q | A |
|---|---|
| Branch? | 2.7 |
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | items 6 and 8 of sebastianbergmann/phpunit-mock-objects#299 (comment) |
| License | MIT |
| Doc PR |
| { | ||
| } | ||
|
|
||
| public function backup($backup) |
There was a problem hiding this comment.
what is the idea behind adding this method? seems arbitrary as it doesn't influence the test.
There was a problem hiding this comment.
You are right. In case the setBackup() method is not present we cannot do anything else than making sure that the code does not break by trying to call a non-existent method.
xabbuh
force-pushed
the
mocking-fixes-2.7
branch
from
1fb3087 to
a45b93d
Compare
|
Thank you @xabbuh. |
Tobion
added a commit
that referenced
this pull request
Mar 24, 2016
This PR was merged into the 2.7 branch. Discussion ---------- [2.7] fix mocking of some methods | Q | A | ------------- | --- | Branch? | 2.7 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | items 6 and 8 of sebastianbergmann/phpunit-mock-objects#299 (comment) | License | MIT | Doc PR | Commits ------- a45b93d [2.7] fix mocking of some methods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.