[HttpFoundation] Fix erasing cookies issue #29676
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rpkamp ok for you? |
nicolas-grekas
changed the title
|
LGTM Although indeed an added test that proves the issue exists (and servers to prevent regressions) would be good 👍 |
…luz) This PR was squashed before being merged into the 4.2 branch (closes symfony#29711). Discussion ---------- Fixed minor typos in an error message | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | no | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files --> | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | - | License | MIT | Doc PR | - Commits ------- 913fdbe Fixed minor typos in an error message
This PR was squashed before being merged into the 4.2 branch (closes symfony#29721). Discussion ---------- [SecurityBundle] Fix traceable voters | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | symfony#29385 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> lets solve the BC break when autowiring individual voters. Commits ------- a7df429 [SecurityBundle] Fix traceable voters
This PR was merged into the 4.2 branch. Discussion ---------- [VarExporter] fix exporting array indexes | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#29715 | License | MIT | Doc PR | Commits ------- 3c936f4 [VarExporter] fix exporting array indexes
fabpot
approved these changes
Jan 1, 2019
Prevent replacing existing cookies when starting or regenerating session on PHP < 7.3 with 'cookie_samesite' option. See issue symfony#29675
|
Thank you @eiannone. |
fabpot
added a commit
that referenced
this pull request
Jan 1, 2019
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #29676). Discussion ---------- [HttpFoundation] Fix erasing cookies issue | Q | A | ------------- | --- | Branch? | 4.2 (to be switched when merging) | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #29675 | License | MIT Prevent replacing existing cookies when starting or regenerating session on PHP < 7.3 with 'cookie_samesite' option. See issue #29675 Commits ------- b40801a Fix erasing cookies issue
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prevent replacing existing cookies when starting or regenerating session on PHP < 7.3 with 'cookie_samesite' option.
See issue #29675