[SecurityBundle] Fix traceable voters #29721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ro0NL
changed the title
|
Does it make sense to add a test which ensures that the original voter class can be retrieved from the compiled container? |
|
updated test to check voters are NOT decorated |
xabbuh
approved these changes
Dec 29, 2018
fabpot
requested changes
Dec 30, 2018
...mfony/Bundle/SecurityBundle/Tests/DependencyInjection/Compiler/AddSecurityVotersPassTest.php
Outdated
Show resolved
Hide resolved
...mfony/Bundle/SecurityBundle/Tests/DependencyInjection/Compiler/AddSecurityVotersPassTest.php
Outdated
Show resolved
Hide resolved
carsonbot
added
Status: Needs Work
and removed
Status: Reviewed
Status: Needs Work
labels
chalasr
approved these changes
Jan 1, 2019
|
Thank you @ro0NL. |
chalasr
pushed a commit
that referenced
this pull request
Jan 1, 2019
This PR was squashed before being merged into the 4.2 branch (closes #29721). Discussion ---------- [SecurityBundle] Fix traceable voters | Q | A | ------------- | --- | Branch? | 4.2 | Bug fix? | yes | New feature? | no | BC breaks? | no <!-- see https://symfony.com/bc --> | Deprecations? | no | Tests pass? | yes <!-- please add some, will be required by reviewers --> | Fixed tickets | #29385 | License | MIT | Doc PR | symfony/symfony-docs#... <!-- required for new features --> lets solve the BC break when autowiring individual voters. Commits ------- a7df429 [SecurityBundle] Fix traceable voters
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lets solve the BC break when autowiring individual voters.