Mention generating absolute urls in UPGRADE files and CHANGELOG #19083
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
zdenekdrahos
commented
Jun 17, 2016
zdenekdrahos
commented
| Q | A |
|---|---|
| Branch? | 2.8+ |
| Bug fix? | no |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #19058 |
| License | MIT |
| Doc PR | - |
| @@ -899,6 +899,31 @@ UPGRADE FROM 2.x to 3.0 | |||
| * The `getMatcherDumperInstance()` and `getGeneratorDumperInstance()` methods in the | |||
| `Symfony\Component\Routing\Router` have been changed from `public` to `protected`. | |||
|
|
|||
| * Deprecated the hardcoded value for the `$referenceType` argument of the `UrlGeneratorInterface::generate` method. | |||
There was a problem hiding this comment.
Maybe removed? Deprecated since 2.8 and removed in 3.0.
There was a problem hiding this comment.
How about:
Use the constants defined in the UrlGeneratorInterface for the $referenceType argument of the UrlGeneratorInterface::generate method.
|
Thank you @zdenekdrahos. |
fabpot
added a commit
that referenced
this pull request
Jun 17, 2016
…ANGELOG (zdenekdrahos) This PR was squashed before being merged into the 2.8 branch (closes #19083). Discussion ---------- Mention generating absolute urls in UPGRADE files and CHANGELOG | Q | A | ------------- | --- | Branch? | 2.8+ | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #19058 | License | MIT | Doc PR | - Commits ------- 5f506d9 Mention generating absolute urls in UPGRADE files and CHANGELOG
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.