[WebProfilerBundle] Fixed the form display in the profiler #12950
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Should I remove the modification on line 423, in case these PR are merged? |
|
I feel that the best would be if @HeahDude included these changes in his pull request to have all related changes in one commit or at least in one pull request (he could cherry pick your changes). |
|
@HeahDude Tell me whenever it's done on your side, that way I'll close mine PR. |
| @@ -414,13 +414,13 @@ | |||
|
|
|||
| {% macro form_tree_entry(name, data, expanded) %} | |||
| <li> | |||
| <div class="tree-inner" data-tab-target-id="{{ data.id }}-details"> | |||
| <div class="tree-inner" data-tab-target-id="{% if data.id is defined %}{{ data.id }}{% endif %}-details"> | |||
There was a problem hiding this comment.
the if check should be around the whole data attribute instead
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With this patch I get the profiler on my form submitted: