Skip to content

[2.6] [WebProfilerBundle] fixes regression introduced in Symfony 2.6 on the form debug panel. #12930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[2.6] [WebProfilerBundle] fixes regression introduced in Symfony 2.6 on the form debug panel. #12930

wants to merge 1 commit into from

Conversation

hhamon
Copy link
Contributor

@hhamon hhamon commented Dec 10, 2014

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets ~
License MIT
Doc PR ~

@hhamon hhamon changed the title [WebProfilerBundle] fixes regression introduced in Symfony 2.6 on the form debug panel. [2.6] [WebProfilerBundle] fixes regression introduced in Symfony 2.6 on the form debug panel. Dec 10, 2014
@hhamon
Copy link
Contributor Author

hhamon commented Dec 10, 2014

@webmozart does this patch look good to you?

@xabbuh
Copy link
Member

xabbuh commented Dec 10, 2014

@hhamon Isn't this a duplicate of #12889?

@hhamon
Copy link
Contributor Author

hhamon commented Dec 10, 2014

Oh yes looks pretty much the same...

@stof
Copy link
Member

stof commented Dec 11, 2014

Given that both type_class and type are used, both should be checked actually. You should not remove the check on data.type being empty

@hhamon
Copy link
Contributor Author

hhamon commented Dec 11, 2014

So in this case I can close my PR as there is already a duplicate?

@xabbuh xabbuh mentioned this pull request Dec 11, 2014
Closed
@hhamon hhamon closed this Dec 11, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hhamon @xabbuh @stof