-
Notifications
You must be signed in to change notification settings - Fork 379
Release/1.6.6 #234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Release/1.6.6 #234
Conversation
Return non-zero rc instead of None
… be passed in similar to post reqeusts
…lso fixed unicode xml decoding error
…e to pass in as a kwarg
Master -> Develop for 1.6.5
Additional headers on every request and fix unicode decoding issue
auto-doc all class constructor parameters
…s_block Add return code for invalid args block
Python's cstringio doesn't support unicode characters, when encountering them Exceptions are raised. We've decided to use stringio instead, trading potential performance improvements for full unicode support. In Python 2, this may lead to a slight performance hit since we're no longer explicitly using the native version. However, in Python 3 stringio will automatically use the native version if available and there should be no noticeable performance changes.
Searchcommands: add full support for unicode
... by using the six library
Make the explorer example compatible w/ Python 3
Use self._connection
Run CI against Splunk 7.2
- Correct logic to always look for cert files when verify=True - Pass key_file and cert_file to handler from HttpLib - Changed default value of verify to False for backward compat
CHANGELOG.md
Outdated
* Add full support for unicode in SearchCommands | ||
* Add return code for invalid_args block | ||
* Fixed unicode xml decoding error | ||
* Added headers argument to get requests so that additional headers can be passed in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are all of these categorized as bug fixes?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let me break them out
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we need to update a user-agent somewhere, double check the release steps
Bug fixes
Minor Changes