Skip to content

Release/1.6.6 #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 25 commits into from
Dec 5, 2018
Merged

Release/1.6.6 #234

merged 25 commits into from
Dec 5, 2018

Conversation

dan1
Copy link
Contributor

@dan1 dan1 commented Dec 5, 2018

Bug fixes

  • Fix ssl verify to require certs when true

Minor Changes

  • Make the explorer example compatible w/ Python 3
  • Add full support for unicode in SearchCommands
  • Add return code for invalid_args block

lybroman-splk and others added 22 commits June 5, 2018 14:19
Return non-zero rc instead of None
Master -> Develop for 1.6.5
Additional headers on every request and fix unicode decoding issue
auto-doc all class constructor parameters
…s_block

Add return code for invalid args block
Python's cstringio doesn't support unicode characters,
when encountering them Exceptions are raised. We've
decided to use stringio instead, trading potential
performance improvements for full unicode support.

In Python 2, this may lead to a slight performance hit
since we're no longer explicitly using the native version.

However, in Python 3 stringio will automatically use the
native version if available and there should be no noticeable
performance changes.
Searchcommands: add full support for unicode
Make the explorer example compatible w/ Python 3
- Correct logic to always look for cert files when verify=True
- Pass key_file and cert_file to handler from HttpLib
- Changed default value of verify to False for backward compat
@dan1 dan1 requested a review from shakeelmohamed December 5, 2018 19:08
CHANGELOG.md Outdated
* Add full support for unicode in SearchCommands
* Add return code for invalid_args block
* Fixed unicode xml decoding error
* Added headers argument to get requests so that additional headers can be passed in
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are all of these categorized as bug fixes?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let me break them out

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

@shakeelmohamed shakeelmohamed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we need to update a user-agent somewhere, double check the release steps

@dan1 dan1 changed the base branch from master to develop December 5, 2018 19:37
@dan1 dan1 changed the base branch from develop to master December 5, 2018 19:37
@dan1 dan1 merged commit e35783d into master Dec 5, 2018
@dan1 dan1 deleted the release/1.6.6 branch December 6, 2018 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants