Skip to content

bpo-42703: Fix incorrect documentation links for asyncio.Event #23881

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 23, 2020
Merged

bpo-42703: Fix incorrect documentation links for asyncio.Event #23881

merged 1 commit into from
Dec 23, 2020

Conversation

mattfowler
Copy link
Contributor

@mattfowler mattfowler commented Dec 21, 2020 •
edited by bedevere-bot
Loading

Fixes issue BPO-42703 where asyncio.Event documentation incorrectly links to the wrong methods.

https://bugs.python.org/issue42703

https://bugs.python.org/issue42703

@the-knights-who-say-ni
Copy link

Hello, and thanks for your contribution!

I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA).

CLA Missing

Our records indicate the following people have not signed the CLA:

@mattfowler

For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue.

If you have recently signed the CLA, please wait at least one business day
before our records are updated.

You can check yourself to see if the CLA has been received.

Thanks again for the contribution, we look forward to reviewing it!

@bedevere-bot bedevere-bot added docs Documentation in the Doc dir awaiting review labels Dec 21, 2020
Fidget-Spinner
Fidget-Spinner approved these changes Dec 21, 2020
View reviewed changes
Copy link
Member

@Fidget-Spinner Fidget-Spinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Good catch and thank you for fixing this!

Btw, renaming your title to bpo-42703: Fix incorrect documentation links for asyncio.Event should make bedevere bot detect your issue number :).

@mattfowler mattfowler changed the title BPO-42703: Fix incorrect documentation links for asyncio.Event bpo-42703: Fix incorrect documentation links for asyncio.Event Dec 21, 2020
ghost
ghost approved these changes Dec 22, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@asvetlov
Copy link
Contributor

Thanks!

@asvetlov asvetlov merged commit d90ff37 into python:master Dec 23, 2020
@miss-islington
Copy link
Contributor

Thanks @mattfowler for the PR, and @asvetlov for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 23, 2020
@mattfowler @miss-islington
BPO-42703: Fix incorrect documentation links for asyncio.Event (pytho…
7825864 
…nGH-23881)

(cherry picked from commit d90ff37)

Co-authored-by: Matt Fowler <matt.fow@gmail.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Dec 23, 2020
@bedevere-bot
Copy link

GH-23908 is a backport of this pull request to the 3.9 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Dec 23, 2020
@mattfowler @miss-islington
BPO-42703: Fix incorrect documentation links for asyncio.Event (pytho…
2dd9064 
…nGH-23881)

(cherry picked from commit d90ff37)

Co-authored-by: Matt Fowler <matt.fow@gmail.com>
@bedevere-bot
Copy link

GH-23909 is a backport of this pull request to the 3.8 branch.

miss-islington added a commit that referenced this pull request Dec 23, 2020
@miss-islington @mattfowler
BPO-42703: Fix incorrect documentation links for asyncio.Event (GH-23881
1e1bacf 
)

(cherry picked from commit d90ff37)

Co-authored-by: Matt Fowler <matt.fow@gmail.com>
miss-islington added a commit that referenced this pull request Dec 23, 2020
@miss-islington @mattfowler
BPO-42703: Fix incorrect documentation links for asyncio.Event (GH-23881
412c935 
)

(cherry picked from commit d90ff37)

Co-authored-by: Matt Fowler <matt.fow@gmail.com>
adorilson pushed a commit to adorilson/cpython that referenced this pull request Mar 13, 2021
@mattfowler @adorilson
BPO-42703: Fix incorrect documentation links for asyncio.Event (pytho…
e60770d 
…nGH-23881)
@erlend-aasland erlend-aasland mentioned this pull request Jul 5, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov asvetlov approved these changes

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@1st1 1st1 Awaiting requested review from 1st1

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mattfowler @the-knights-who-say-ni @asvetlov @miss-islington @bedevere-bot @Fidget-Spinner @shihai1991