Skip to content

bpo-41676: fix links to asyncio.Event.wait #22029

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

graingert
Copy link
Contributor

@graingert graingert commented Aug 31, 2020

@@ -105,7 +105,7 @@ Event

An Event object manages an internal flag that can be set to *true*
with the :meth:`set` method and reset to *false* with the
:meth:`clear` method. The :meth:`wait` method blocks until the
:meth:`clear` method. The :meth:`~asyncio.Event.wait` method blocks until the
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is odd, right? is this a sphinx bug?

@tirkarthi tirkarthi changed the title fix links to asyncio.Event.wait bpo-41676: fix links to asyncio.Event.wait Aug 31, 2020
@fochoao

This comment has been minimized.

@fochoao

This comment has been minimized.

@fochoao

This comment has been minimized.

@graingert

This comment has been minimized.

@fochoao

This comment has been minimized.

@graingert
Copy link
Contributor Author

@fochoao I don't think this is the correct pull request

@fochoao

This comment has been minimized.

@graingert

This comment has been minimized.

@@ -0,0 +1 @@
fix links to `asyncio.Event.wait`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bit cryptic for a news entry (fixed links where?)

I'm not sure a news entry is needed for this, but if it is then maybe something like "Fixed broken links in asyncio documentation".

@erlend-aasland
Copy link
Contributor

Fixed by #23881.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
awaiting review docs Documentation in the Doc dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants