fix: pin colored to <1.5.0 #385
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Colored 1.5.0 introduced breaking API changes, renaming functions `fg` and `attr` to `fore` and `style` respectively.
|
Colored's maintainer noticed the problem and deleted Colored 1.5.0. He released a 2.0.0 version instead. This PR is still required, since robotics-toolbox-python does not support the breaking changes in colored 2.0.0. |
|
Thanks for your interest in the Toolbox and for submitting this PR. This issue has been resolved by the author of coloured for versions beyond 2.0.0, and existing Toolbox code works as expected. Therefore I will decline this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @petercorke! This PR fixes #384.
Colored 1.5.0 introduced breaking API changes, renaming functions
fgandattrtoforeandstylerespectively. This PR pins colored's version to<1.5.0.