Various fix for your PR #1
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there,
I tested your PR more thoroughly, and found some issues.
At first I thought it would be a quick fix, but actually it took quite some time. Anyway, here is the changes needed to have something mergeable in my repo !
So the main issue was that in the github actions, we are not using
link
anymore. Instead, we build that link from theversion
given by the user.The issue is that in many open-source projects, the tag is named something like
v1.2
. But if the user enter1.2
, then the link generated ishttps://github.com/user/project@1.2
, which doesn't exist because there is no tag1.2
(it should bev1.2
). Of course it can be in the opposite way as well (user specifyv1.2
but the tag is1.2
).But I still think your change is better (no need to specify a version AND a link, just specify the version). So I clarified it in the github action input description (mentioning we need the tag). Then in the github action, I clean the
v1.2
to1.2
if needed.I also improved the detection of "pre-release" versions (not only
dev
, but alsorc
,a
, andb
) -> see PEP 440I also modernized many
format
into f-strings.Also in the index file, by default it shows the latest version, even if it's pre-release. I changed it so instead it shows the latest stable version, I think it's better, but what's your opinion ?

I also removed some remaining anchor tags, to make sure this is compliant to PEP503
And finally, I updated the
update_pkgs.py
script (by the way, this is such a great idea, now it's super easy to test new changes !!!) to not call subprocesses, but use python directly.And I fixed the tag names in there, so the links work. Also added a dev version for
public-hello
in order to have an example in the template (for the pre-release tag) !