Skip to content

General fix and update styles #71

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 25 commits into from
Dec 31, 2023
Merged

General fix and update styles #71

merged 25 commits into from
Dec 31, 2023

Conversation

pabnas
Copy link
Contributor

@pabnas pabnas commented Dec 28, 2023 •
edited
Loading

I did some changes in order to make it more organized

  • Create a static folder so all packages have the same js and css
  • Update the workflows and actions so it is more easy to do everything
  • In the package page add a return button, a versioning selector indicating what is the latest stable and what is a prerelease (for now it is only those version that contains the word dev)
  • Load the Readme file as the description using Markedjs
image

@pabnas pabnas mentioned this pull request Dec 28, 2023
Closed
@astariul astariul self-requested a review December 28, 2023 05:43
astariul
astariul reviewed Dec 28, 2023
View reviewed changes
astariul
astariul reviewed Dec 28, 2023
View reviewed changes
astariul
astariul reviewed Dec 28, 2023
View reviewed changes
@astariul
Copy link
Owner

Hey, thanks a lot for the PR !

I think these changes are very pertinent and improve the projet in many ways.
I particularly love pulling the README from the repo !

Also I like the latest and prerelease tags, but they disappear when clicking another version :
Screen Shot 2023-12-28 at 4 40 35 PM
Screen Shot 2023-12-28 at 4 40 47 PM

Is it expected ? Wouldn't it be better to keep it visible so we know which one is the latest stable, and which one is the pre-release ?

Also please see my other comments so we can merge !

@pabnas
Copy link
Contributor Author

pabnas commented Dec 28, 2023 •
edited
Loading

yeah didn't notice that, i will update that and apply the changes, i think the only tag that should stay always is the Latest stable just to avoid to having a lot of Prerelease tags.

@pabnas pabnas requested a review from astariul December 29, 2023 03:10
astariul
astariul reviewed Dec 29, 2023
View reviewed changes
astariul
astariul reviewed Dec 29, 2023
View reviewed changes
@pabnas pabnas requested a review from astariul December 29, 2023 04:48
astariul
astariul approved these changes Dec 29, 2023
View reviewed changes
Copy link
Owner

@astariul astariul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ! This evening I'll do more testing (I didn't really test it myself yet) and merge it.

Thanks again for the great PR and the many new features ! Love it.

astariul
astariul requested changes Dec 29, 2023
View reviewed changes
Copy link
Owner

@astariul astariul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After testing more thoroughly, I found some issues.

I created a PR into your branch with my changes to make it mergeable, see pabnas#1

@pabnas pabnas requested a review from astariul December 31, 2023 04:00
astariul
astariul approved these changes Dec 31, 2023
View reviewed changes
Copy link
Owner

@astariul astariul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome ! So glad we made it work 💯

@astariul astariul merged commit 92a9cd5 into astariul:main Dec 31, 2023
@pabnas pabnas deleted the general_fix_and_update_styles branch December 31, 2023 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@astariul astariul astariul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pabnas @astariul