Skip to content

Don't misclip axis when calling set_ticks on inverted axes. #14677

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 3, 2019
Merged

Don't misclip axis when calling set_ticks on inverted axes. #14677

merged 1 commit into from
Jul 3, 2019

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Jul 2, 2019

due to a small inversion in 0e41317 (compare https://github.com/matplotlib/matplotlib/pull/14579/files#diff-52127080e2783464f529df684d82d476L2145 and https://github.com/matplotlib/matplotlib/pull/14579/files#diff-52127080e2783464f529df684d82d476R1908)...

Closes #14675.

PR Summary

PR Checklist

  • Has Pytest style unit tests
  • Code is Flake 8 compliant
  • New features are documented, with examples if plot related
  • Documentation is sphinx and numpydoc compliant
  • Added an entry to doc/users/next_whats_new/ if major new feature (follow instructions in README.rst there)
  • Documented in doc/api/api_changes.rst if API changed in a backward-incompatible way

@anntzer anntzer added the Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions. label Jul 2, 2019
@anntzer anntzer added this to the v3.1.2 milestone Jul 2, 2019
@anntzer anntzer mentioned this pull request Jul 2, 2019
Closed
@jklymak
Copy link
Member

jklymak commented Jul 2, 2019

Looks right, but AttributeError: 'AxesSubplot' object has no attribute 'set_ticks'

@anntzer anntzer force-pushed the set_ticks-inverted branch from e189dd4 to 557375f Compare July 2, 2019 22:54
@anntzer
Copy link
Contributor Author

anntzer commented Jul 2, 2019

oops, fixed

@tacaswell tacaswell merged commit 21a55d3 into matplotlib:master Jul 3, 2019
@anntzer anntzer deleted the set_ticks-inverted branch July 3, 2019 06:53
@jklymak jklymak mentioned this pull request Jul 6, 2019
Closed
@rebeccabilbro rebeccabilbro mentioned this pull request Jul 6, 2019
Merged
This was referenced Jul 10, 2019
Closed
Closed
@QuLogic
Copy link
Member

QuLogic commented Jul 17, 2019

@meeseeksdev backport to v3.1.x

meeseeksmachine pushed a commit to meeseeksmachine/matplotlib that referenced this pull request Jul 17, 2019
@tacaswell
Backport PR matplotlib#14677: Don't misclip axis when calling set_tic…
407a9fe 
…ks on inverted axes.
@meeseeksmachine meeseeksmachine mentioned this pull request Jul 17, 2019
Merged
QuLogic added a commit that referenced this pull request Jul 17, 2019
@QuLogic
Merge pull request #14816 from meeseeksmachine/auto-backport-of-pr-14…
bba6db3 
…677-on-v3.1.x

Backport PR #14677 on branch v3.1.x (Don't misclip axis when calling set_ticks on inverted axes.)
@anntzer anntzer mentioned this pull request Jul 27, 2019
Closed
This was referenced Aug 29, 2019
Closed
Closed
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Sep 12, 2019
Closed
@ImportanceOfBeingErnest ImportanceOfBeingErnest mentioned this pull request Oct 3, 2019
Closed
@tacaswell tacaswell mentioned this pull request Nov 6, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklymak jklymak jklymak approved these changes

Assignees
No one assigned
Labels
Release critical For bugs that make the library unusable (segfaults, incorrect plots, etc) and major regressions.
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.

Heatmaps are being truncated when using with seaborn
4 participants
@anntzer @jklymak @QuLogic @tacaswell