Skip to content

CPP: Speed up startsWithIfndef. #331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 18, 2018
Merged

CPP: Speed up startsWithIfndef. #331

merged 1 commit into from
Oct 18, 2018

Conversation

geoffw0
Copy link
Contributor

@geoffw0 geoffw0 commented Oct 17, 2018

This in turn speeds up 'AV Rule 35.ql' on large snapshots, though the effect is usually much less significant than #313.

@geoffw0 geoffw0 added the C++ label Oct 17, 2018
@geoffw0
Copy link
Contributor Author

geoffw0 commented Oct 18, 2018

@rdmarsh2 please review?

rdmarsh2
rdmarsh2 approved these changes Oct 18, 2018
View reviewed changes
Copy link
Contributor

@rdmarsh2 rdmarsh2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rdmarsh2 rdmarsh2 merged commit 36a1ac5 into github:master Oct 18, 2018
aibaars added a commit that referenced this pull request Oct 14, 2021
@aibaars
Merge pull request #331 from github/aibaars/remove-unsafe
2a32b59 
Remove use of 'unsafe'
@geoffw0 geoffw0 deleted the av-35b branch February 10, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdmarsh2 rdmarsh2 rdmarsh2 approved these changes

Assignees
No one assigned
Labels
C++
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@geoffw0 @rdmarsh2