CPP: Fix hasXMacro performance. #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rdmarsh2 please review? |
|
@aibaars @adityasharad I believe this change should go into the 1.18.1 patch in addition to master. Can you handle this for me or shall I make a duplicate of this PR onto 1.18.1? |
|
@geoffw0 Please make another PR against |
|
Done: #343 |
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
Remove unicode character from doc string
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Apr 16, 2022
…op-ref Fix property references to fake overrides
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a performance issue in 'AV Rule 35.ql's
hasXMacro, that was affecting some larger snapshots.