Skip to content

Implement intersection monoid and semigroup #391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Nov 3, 2019
Merged

Implement intersection monoid and semigroup #391

merged 21 commits into from
Nov 3, 2019

Conversation

toxyduck
Copy link
Contributor

@codecov-io
Copy link

codecov-io commented Oct 20, 2019 •
edited
Loading

Codecov Report

Merging #391 into series/5.x will increase coverage by 0.14%.
The diff coverage is 100%.

Impacted file tree graph

@@               Coverage Diff                @@
##             series/5.x     #391      +/-   ##
================================================
+ Coverage         49.74%   49.89%   +0.14%     
- Complexity         2328     2341      +13     
================================================
  Files               153      154       +1     
  Lines              9100     9115      +15     
  Branches            490      490              
================================================
+ Hits               4527     4548      +21     
+ Misses             4426     4421       -5     
+ Partials            147      146       -1
Impacted Files Coverage Δ Complexity Δ
core/src/main/java/fj/Monoid.java 49.02% <100%> (+2.23%) 24 <1> (+2) ⬆️
core/src/main/java/fj/Semigroup.java 64.22% <100%> (+0.33%) 28 <1> (+1) ⬆️
core/src/main/java/fj/data/Enumerator.java 53.39% <100%> (+0.92%) 17 <2> (+2) ⬆️
core/src/main/java/fj/Bounded.java 100% <100%> (ø) 5 <5> (?)
core/src/main/java/fj/data/Stream.java 69.33% <0%> (+0.34%) 154% <0%> (+1%) ⬆️
core/src/main/java/fj/data/Set.java 83.24% <0%> (+1.11%) 103% <0%> (+2%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedeb3d...dc9e0a9. Read the comment docs.

@toxyduck toxyduck changed the title Implement intersection monoid and semigroup WIP: Implement intersection monoid and semigroup Oct 21, 2019
@gliptak gliptak mentioned this pull request Oct 21, 2019
Closed
@toxyduck toxyduck changed the title WIP: Implement intersection monoid and semigroup Implement intersection monoid and semigroup Oct 21, 2019
@toxyduck
Copy link
Contributor Author

@jbgi Please, review

jbgi
jbgi requested changes Nov 2, 2019
View reviewed changes
Copy link
Member

@jbgi jbgi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR, thanks! some small adjustments and we can merge.

jbgi
jbgi reviewed Nov 2, 2019
View reviewed changes
@toxyduck toxyduck requested a review from jbgi November 3, 2019 13:14
@jbgi jbgi merged commit e287a58 into functionaljava:series/5.x Nov 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbgi jbgi jbgi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@toxyduck @codecov-io @jbgi