Skip to content

Implement Bounded typeclass #390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

toxyduck
Copy link
Contributor

@codecov-io
Copy link

Codecov Report

Merging #390 into series/5.x will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@               Coverage Diff               @@
##             series/5.x     #390     +/-   ##
===============================================
- Coverage         49.74%   49.65%   -0.1%     
+ Complexity         2328     2325      -3     
===============================================
  Files               153      154      +1     
  Lines              9100     9109      +9     
  Branches            490      490             
===============================================
- Hits               4527     4523      -4     
- Misses             4426     4438     +12     
- Partials            147      148      +1
Impacted Files Coverage Δ Complexity Δ
core/src/main/java/fj/Bounded.java 0% <0%> (ø) 0 <0> (?)
core/src/main/java/fj/Ord.java 44.29% <0%> (-3.36%) 34% <0%> (-4%)
core/src/main/java/fj/data/Stream.java 69.33% <0%> (+0.34%) 154% <0%> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eedeb3d...ea6fcc7. Read the comment docs.

@gliptak
Copy link
Contributor

gliptak commented Oct 21, 2019

How is this different from #391?

@toxyduck
Copy link
Contributor Author

@jbgi in #363 asked to separate into two PR's

@jbgi
Copy link
Member

jbgi commented Nov 2, 2019

@yaroslavok well, since all of this PR is in #391 let's close this one.

@jbgi jbgi closed this Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants