Skip to content

add explicit ::boost namespace to make_optional in uri_parts.hpp #869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 21, 2019
Merged

add explicit ::boost namespace to make_optional in uri_parts.hpp #869

merged 1 commit into from
Jan 21, 2019

Conversation

egendron93
Copy link

Hello,
I did not see a pull requests made for issue #863 and needed it patched in order to build cpp-netlib with c++17.

@egendron93
Copy link
Author

@glynos @deanberris Sorry forgot to add reviewers.

@egendron93 egendron93 closed this Jan 16, 2019
@egendron93 egendron93 reopened this Jan 16, 2019
deanberris
deanberris approved these changes Jan 21, 2019
View reviewed changes
Copy link
Member

@deanberris deanberris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks!

@deanberris deanberris merged commit 0a4d2a6 into cpp-netlib:0.13-release Jan 21, 2019
@egendron93 egendron93 deleted the 0.13-release-integration branch January 21, 2019 15:10
@maingoh maingoh mentioned this pull request Sep 17, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deanberris deanberris deanberris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@egendron93 @deanberris