Skip to content

Explicitely set boost namespace when using make_optional. #880

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

maingoh
Copy link

@maingoh maingoh commented Sep 16, 2019

Following #869

Avoid conflicting with std::make_optional from c++17 (g++7.4.0).

/usr/include/boost/network/protocol/http/message/async_message.hpp:100:24: error: no match for 'operator=' (operand types are 'boost::optional<std::multimap<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char>, boost::network::impl::is_less_ignore_case_impl> >' and 'std::optional<std::multimap<std::__cxx11::basic_string<char>, std::__cxx11::basic_string<char>, boost::network::impl::is_less_ignore_case_impl> >')
     retrieved_headers_ = make_optional(raw_headers);

Probably optional should also be replaced by boost::optional, but in my case it was enough for the compiler to deduce the types.

@maingoh
Copy link
Author

maingoh commented Sep 17, 2019

Tests are not passing for some reason ?

@maingoh
Copy link
Author

maingoh commented Oct 4, 2019

@deanberris any plan to merge this ? I would prefer to rely on the official repository than my own fork :)

@glynos
Copy link
Member

glynos commented Oct 4, 2019

The CI failures are not caused by the changes in the commit.

LGTM

@glynos glynos merged commit 2b8406e into cpp-netlib:0.13-release Oct 4, 2019
@maingoh maingoh deleted the set_namespace_make_optional branch October 4, 2019 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants