Skip to content

Use EXPECT_FALSE instead of EXPECT_EQ(false, X) #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Apr 6, 2017
Merged

Use EXPECT_FALSE instead of EXPECT_EQ(false, X) #752

merged 21 commits into from
Apr 6, 2017

Conversation

deanberris
Copy link
Member

This fixes the failures we're finding from the CI builds.

deanberris added 21 commits April 6, 2017 16:30
@deanberris
Use EXPECT_FALSE instead of EXPECT_EQ(false, X)
ea14831 
This fixes the failures we're finding from the CI builds.
@deanberris
squash: fix response tests too
a3c79e0
@deanberris
squash: let make determine the number of jobs
2300c60
@deanberris
squash: use ccache for the build
0f42783
@deanberris
squash: set the compiler version properly
9a1121d
@deanberris
squash: use clang-3.8 as test compiler
ea626d6
@deanberris
squash: exclude asan and tsan builds from g++ matrix
8ef8677
@deanberris
squash: do not use ${HOME}
47d91b2
@deanberris
squash: remove cache until we can make it work
dab4bd4
@deanberris
squash: try installing ccache from testing too
2dd328e
@deanberris
squash: fix link to c compiler
4289ca9
@deanberris
squash: still not use ccache
009e2d5
@deanberris
squash: remove ccache installation for now
fcf669d
@deanberris
squash: use boost array/chrono for 1.55
5219b94
@deanberris
squash: try ccache again
d42f0b3
@deanberris
squash: add proper boost.asio defines for supporting clang
a344712
@deanberris
squash: fix travis config
9050af6
@deanberris
squash: script better
1243a50
@deanberris
squash: add more boost.asio config options
b6cd5c4
@deanberris
squash: use boost thread v3
5a39a86
@deanberris
squash: use libstdc++ explicitly on Linux when using clang
17cef53
@deanberris
Copy link
Member Author

The clang failures I cannot reproduce locally, with Boost 1.55. The ASAN build suggests that there's something funny going on in either cleanup or in the semantics of some of the Boost.Thread internals. Maybe switching again to using std::thread and the standard library futures would work, I'll follow-up on that next.

@deanberris deanberris merged commit f872859 into cpp-netlib:master Apr 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@deanberris