Skip to content

Use EXPECT_FALSE instead of EXPECT_EQ(false, X) #752

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Apr 6, 2017
Merged

Use EXPECT_FALSE instead of EXPECT_EQ(false, X) #752

Changes from 1 commit
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
ea14831
Use EXPECT_FALSE instead of EXPECT_EQ(false, X)
deanberris Apr 6, 2017
a3c79e0
squash: fix response tests too
deanberris Apr 6, 2017
2300c60
squash: let make determine the number of jobs
deanberris Apr 6, 2017
0f42783
squash: use ccache for the build
deanberris Apr 6, 2017
9a1121d
squash: set the compiler version properly
deanberris Apr 6, 2017
ea626d6
squash: use clang-3.8 as test compiler
deanberris Apr 6, 2017
8ef8677
squash: exclude asan and tsan builds from g++ matrix
deanberris Apr 6, 2017
47d91b2
squash: do not use ${HOME}
deanberris Apr 6, 2017
dab4bd4
squash: remove cache until we can make it work
deanberris Apr 6, 2017
2dd328e
squash: try installing ccache from testing too
deanberris Apr 6, 2017
4289ca9
squash: fix link to c compiler
deanberris Apr 6, 2017
009e2d5
squash: still not use ccache
deanberris Apr 6, 2017
fcf669d
squash: remove ccache installation for now
deanberris Apr 6, 2017
5219b94
squash: use boost array/chrono for 1.55
deanberris Apr 6, 2017
d42f0b3
squash: try ccache again
deanberris Apr 6, 2017
a344712
squash: add proper boost.asio defines for supporting clang
deanberris Apr 6, 2017
9050af6
squash: fix travis config
deanberris Apr 6, 2017
1243a50
squash: script better
deanberris Apr 6, 2017
b6cd5c4
squash: add more boost.asio config options
deanberris Apr 6, 2017
5a39a86
squash: use boost thread v3
deanberris Apr 6, 2017
17cef53
squash: use libstdc++ explicitly on Linux when using clang
deanberris Apr 6, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Use EXPECT_FALSE instead of EXPECT_EQ(false, X) 
This fixes the failures we're finding from the CI builds.
  • Loading branch information
@deanberris
deanberris committed Apr 6, 2017
commit ea148313318111cd1dd433bec376bd29c7899d25
10 changes: 5 additions & 5 deletions libs/network/test/http/request_incremental_parser_test.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ TEST(IncrementalRequestParserTest, ParseMethod) {
p.reset();
std::tie(parsed_ok, result_range) =
p.parse_until(request_parser_type::method_done, invalid_http_method);
EXPECT_EQ(false, parsed_ok);
EXPECT_FALSE(parsed_ok);
parsed.assign(std::begin(result_range), std::end(result_range));
std::cout << "PARSED: " << parsed << " [state:" << p.state() << "] "
<< std::endl;
Expand All @@ -68,7 +68,7 @@ TEST(IncrementalRequestParserTest, ParseURI) {
std::string valid_http_request = "GET / HTTP/1.1\r\n";
std::tie(parsed_ok, result_range) =
p.parse_until(request_parser_type::uri_done, valid_http_request);
EXPECT_EQ(true, parsed_ok);
EXPECT_TRUE(parsed_ok);
EXPECT_FALSE(boost::empty(result_range));
std::string parsed(std::begin(result_range), std::end(result_range));
std::cout << "PARSED: " << parsed << " [state:" << p.state() << "] "
Expand All @@ -78,7 +78,7 @@ TEST(IncrementalRequestParserTest, ParseURI) {
p.reset();
std::tie(parsed_ok, result_range) =
p.parse_until(request_parser_type::uri_done, invalid_http_request);
EXPECT_EQ(false, parsed_ok);
EXPECT_FALSE(parsed_ok);
parsed.assign(std::begin(result_range), std::end(result_range));
std::cout << "PARSED: " << parsed << " [state:" << p.state() << "] "
<< std::endl;
Expand All @@ -104,7 +104,7 @@ TEST(IncrementalRequestParserTest, ParseHTTPVersion) {
p.reset();
std::tie(parsed_ok, result_range) =
p.parse_until(request_parser_type::version_done, invalid_http_request);
EXPECT_EQ(false, parsed_ok);
EXPECT_FALSE(parsed_ok);
parsed.assign(std::begin(result_range), std::end(result_range));
std::cout << "PARSED: " << parsed << " [state:" << p.state() << "] "
<< std::endl;
Expand All @@ -121,7 +121,7 @@ TEST(IncrementalRequestParserTest, ParseHTTPHeaders) {
"GET / HTTP/1.1\r\nHost: cpp-netlib.org\r\n\r\n";
std::tie(parsed_ok, result_range) =
p.parse_until(request_parser_type::headers_done, valid_http_request);
EXPECT_EQ(true, parsed_ok);
EXPECT_TRUE(parsed_ok);
EXPECT_FALSE(boost::empty(result_range));
std::string parsed(std::begin(result_range), std::end(result_range));
std::cout << "PARSED: " << parsed << " [state:" << p.state() << "] "
Expand Down