Skip to content

chore: drop unsupported python version 3.8 #229

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 30, 2025
Merged

chore: drop unsupported python version 3.8 #229

merged 1 commit into from
Mar 30, 2025

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Mar 30, 2025 •
edited by coderabbitai bot
Loading

see https://devguide.python.org/versions/#unsupported-versions

Summary by CodeRabbit

  • Chores
    • Updated the supported Python versions to require Python 3.9 and above, ensuring compatibility with modern environments.

@shenxianpeng shenxianpeng added the enhancement New feature or request label Mar 30, 2025
@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Mar 30, 2025 •
edited
Loading

Walkthrough

This pull request updates the project's Python version support. It removes Python 3.8 from the CI testing matrix in the GitHub Actions workflow and updates the project configuration in pyproject.toml to require Python ≥3.9. The change also removes classifiers related to Python 3.8 and the generic Python 3 only classifier.

Changes

File(s) Change Summary
.github/.../main.yml
pyproject.toml		 Removed Python 3.8 support: updated the GitHub Actions matrix by excluding Python 3.8 and modified pyproject.toml by changing requires-python to ">=3.9" and removing Python 3.8-specific classifiers.

Possibly related PRs

Poem

I'm a rabbit in a coding field,
Hopping past versions, new yields revealed.
Python 3.8 hops out of sight,
Leaving ≥3.9 shining bright.
With whiskers twitching in delight,
I celebrate changes with a joyful byte!
🐇💻

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between bd71280 and f864646.

📒 Files selected for processing (2)
  • .github/workflows/main.yml (1 hunks)
  • pyproject.toml (1 hunks)
🔇 Additional comments (3)
.github/workflows/main.yml (1)

56-57: Python Version Matrix Updated
The Python version matrix has been updated to remove Python 3.8, ensuring that only supported versions (3.9 to 3.13) are used during CI. This aligns perfectly with the updated support policy.

pyproject.toml (2)

14-14: Update Minimum Python Requirement
The requires-python field has been updated from ">=3.8" to ">=3.9" to enforce support only for the newer Python versions.

16-31: Clean Up Python Classifiers
Outdated classifiers such as "Programming Language :: Python :: 3 :: Only" and "Programming Language :: Python :: 3.8" have been removed. The remaining classifiers now accurately reflect support for Python 3.9 through 3.13.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov Codecov
Copy link

codecov bot commented Mar 30, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (bd71280) to head (f864646).
Report is 1 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff            @@
##              main      #229   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            7         7           
  Lines          290       290           
=========================================
  Hits           290       290

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@shenxianpeng shenxianpeng merged commit 6d7b405 into main Mar 30, 2025
26 checks passed
@shenxianpeng shenxianpeng deleted the drop-py38 branch March 30, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@shenxianpeng