Skip to content

chore: update pyproject.toml to drop python 3.7 #196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 12, 2024
Merged

chore: update pyproject.toml to drop python 3.7 #196

merged 1 commit into from
Nov 12, 2024

Conversation

shenxianpeng
Copy link
Contributor

@shenxianpeng shenxianpeng commented Nov 12, 2024 •
edited by coderabbitai bot
Loading

Summary by CodeRabbit

Summary by CodeRabbit

  • Chores
    • Updated project metadata and dependencies in the configuration file.
    • Removed support for Python 3.7.
    • Defined a new script entry point for commit-check.
    • Configured type checking and test coverage settings.

@shenxianpeng shenxianpeng marked this pull request as ready for review November 12, 2024 22:31
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 12, 2024 •
edited
Loading

Caution

Review failed

The pull request is closed.

Walkthrough

The pull request involves modifications to the pyproject.toml file, focusing on project metadata and dependencies. Key changes include the removal of support for Python 3.7, updates to the minimum setuptools version, and adjustments to the dependencies section. Additionally, script entry points and configurations for type checking and test coverage have been defined, refining the project's overall setup without impacting core functionality.

Changes

File Change Summary
pyproject.toml - Removed classifier for "Programming Language :: Python :: 3.7".
- Set minimum setuptools version to 61.
- dependencies section unchanged for pyyaml.
- Added script entry point for commit-check.
- Specified package name as ["commit_check"] and set non-zip-safe.
- Outlined versioning strategies in [tool.setuptools_scm].
- Configured [tool.mypy] and [tool.coverage] for type checking and coverage reports.

Poem

🐇 In the garden of code, we prune and we play,
Removing old branches, making way for the day.
With scripts set to run and dependencies neat,
Our project now dances on digital feet!
So hop with delight, let the changes take flight,
For every new version brings joy to our sight! 🌼

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@shenxianpeng shenxianpeng changed the title chore: update pyproject.toml to remove python 3.7 chore: update pyproject.toml to drop python 3.7 Nov 12, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 12, 2024 •
edited
Loading

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.27%. Comparing base (3ec5112) to head (772e93a).
Report is 2 commits behind head on main.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main     #196   +/-   ##
=======================================
  Coverage   97.27%   97.27%           
=======================================
  Files           7        7           
  Lines         294      294           
=======================================
  Hits          286      286           
  Misses          8        8

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@shenxianpeng shenxianpeng merged commit 67a6560 into main Nov 12, 2024
24 of 25 checks passed
@shenxianpeng shenxianpeng deleted the shenxianpeng-patch-1 branch November 12, 2024 22:34
@shenxianpeng shenxianpeng added the enhancement New feature or request label Nov 14, 2024
This was referenced Mar 30, 2025
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shenxianpeng @codecov-commenter