fix: allow non-HTTP URIs in OAuth2 provider redirect URIs #18880
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jul 15, 2025
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
ThomasK33
force-pushed
the
thomask33/07-15-fix_oauth2_allow_custom_uri_schemes_without_reverse_domain_notation_for_native_apps
branch
from
80b2b40 to
a29e00a
Compare
ThomasK33
force-pushed
the
thomask33/07-14-feat_oauth2_add_bulk_token_revocation_endpoint_with_usage_tracking
branch
from
4e82d80 to
8830706
Compare
ThomasK33
force-pushed
the
thomask33/07-15-fix_oauth2_allow_custom_uri_schemes_without_reverse_domain_notation_for_native_apps
branch
from
a29e00a to
63934b4
Compare
ThomasK33
force-pushed
the
thomask33/07-14-feat_oauth2_add_bulk_token_revocation_endpoint_with_usage_tracking
branch
from
8830706 to
13de8e2
Compare
… for native apps Change-Id: I4000cd39caa994efe0b76c4984e968f2963063ca Signed-off-by: Thomas Kosiewski <tk@coder.com>
ThomasK33
force-pushed
the
thomask33/07-15-fix_oauth2_allow_custom_uri_schemes_without_reverse_domain_notation_for_native_apps
branch
from
d9ecda1 to
0b47133
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed OAuth2 redirect URI validation to accept custom URI schemes
This PR updates the validation for OAuth2 provider app redirect URIs to use the more flexible
urivalidator instead of the stricterhttp_urlvalidator. This allows for custom URI schemes that don't follow reverse domain notation, while still blocking well-known schemes like http, https, ftp, etc.The change removes the requirement that custom schemes must contain a period, making the validation more permissive for various client applications while maintaining security by continuing to block well-known schemes.