Skip to content

feat: add OAuth2 client credentials grant type and user ownership #18841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens
Choose a base branch
from

Conversation

ThomasK33
Copy link
Member

  • Add client_credentials to OAuth2ProviderGrantType enum
  • Add user_id column to oauth2_provider_apps for ownership tracking
  • Make refresh_hash nullable for client credentials tokens per RFC 6749
  • Update API schemas to use proper OAuth2 enums for grant/response types
  • Add grant_types field to OAuth2 app create/update requests
  • Support user-scoped client credentials apps vs system-scoped auth flows
  • Update database queries and models for new fields

Change-Id: I11901919656c86c51e7c808324e2df5205eda002
Signed-off-by: Thomas Kosiewski tk@coder.com

Copy link
Member Author

ThomasK33 commented Jul 12, 2025

@ThomasK33 ThomasK33 changed the title feat(oauth2): add client credentials grant type and user ownership feat: add OAuth2 client credentials grant type and user ownership Jul 12, 2025
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch 3 times, most recently from bd2e4f2 to f44982c Compare July 12, 2025 14:41
@ThomasK33 ThomasK33 marked this pull request as ready for review July 13, 2025 10:36
@ThomasK33 ThomasK33 requested review from Emyrk and johnstcn July 13, 2025 10:36
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 50a22db to 93a1a1d Compare July 14, 2025 12:43
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from f44982c to c654948 Compare July 14, 2025 12:43
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from c654948 to eac2681 Compare July 14, 2025 16:22
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 93a1a1d to 5c7f06a Compare July 14, 2025 16:22
@ThomasK33 ThomasK33 changed the base branch from thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens to graphite-base/18841 July 14, 2025 17:10
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from eac2681 to ac0d1f6 Compare July 14, 2025 17:18
@ThomasK33 ThomasK33 force-pushed the graphite-base/18841 branch from 5c7f06a to 0393465 Compare July 14, 2025 17:18
@ThomasK33 ThomasK33 changed the base branch from graphite-base/18841 to thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens July 14, 2025 17:19
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from ac0d1f6 to ef3c66e Compare July 15, 2025 17:27
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 0393465 to 643824a Compare July 15, 2025 17:27
- Add client_credentials to OAuth2ProviderGrantType enum
- Add user_id column to oauth2_provider_apps for ownership tracking
- Make refresh_hash nullable for client credentials tokens per RFC 6749
- Update API schemas to use proper OAuth2 enums for grant/response types
- Add grant_types field to OAuth2 app create/update requests
- Support user-scoped client credentials apps vs system-scoped auth flows
- Update database queries and models for new fields

Change-Id: I11901919656c86c51e7c808324e2df5205eda002
Signed-off-by: Thomas Kosiewski <tk@coder.com>
@ThomasK33 ThomasK33 force-pushed the thomask33/07-10-feat_add_cleanup_for_expired_oauth2_provider_app_codes_and_tokens branch from 643824a to f2c16b5 Compare July 17, 2025 14:38
@ThomasK33 ThomasK33 requested a review from aslilac as a code owner July 17, 2025 14:38
@ThomasK33 ThomasK33 force-pushed the thomask33/07-12-feat_oauth2_add_client_credentials_grant_type_and_user_ownership branch from ef3c66e to 3f1495c Compare July 17, 2025 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant