Skip to content

fix: Manually format external URL #1168

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 25, 2022
Merged

fix: Manually format external URL #1168

merged 1 commit into from
Apr 25, 2022

Conversation

kylecarbs
Copy link
Member

path.Join escaped the double slash!

@kylecarbs kylecarbs requested a review from code-asher April 25, 2022 21:41
@kylecarbs kylecarbs self-assigned this Apr 25, 2022
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 21:41
@codecov
Copy link

codecov bot commented Apr 25, 2022

Codecov Report

Merging #1168 (a411b92) into main (4f7ceeb) will increase coverage by 0.18%.
The diff coverage is 65.21%.

@@            Coverage Diff             @@
##             main    #1168      +/-   ##
==========================================
+ Coverage   66.25%   66.43%   +0.18%     
==========================================
  Files         263      263              
  Lines       16566    16573       +7     
  Branches      156      156              
==========================================
+ Hits        10975    11010      +35     
+ Misses       4449     4428      -21     
+ Partials     1142     1135       -7     
Flag Coverage Δ
unittest-go-macos-latest 53.85% <65.21%> (+0.21%) ⬆️
unittest-go-postgres- 65.59% <65.21%> (+<0.01%) ⬆️
unittest-go-ubuntu-latest 56.24% <65.21%> (+0.05%) ⬆️
unittest-go-windows-2022 53.27% <65.21%> (+0.07%) ⬆️
unittest-js 67.45% <ø> (+0.02%) ⬆️
Impacted Files Coverage Δ
buildinfo/buildinfo.go 61.70% <65.21%> (+5.60%) ⬆️
peerbroker/listen.go 84.03% <0.00%> (-3.37%) ⬇️
peer/channel.go 83.23% <0.00%> (-0.58%) ⬇️
coderd/provisionerdaemons.go 62.79% <0.00%> (ø)
site/src/components/SignInForm/SignInForm.tsx 100.00% <0.00%> (ø)
provisionerd/provisionerd.go 76.76% <0.00%> (+0.53%) ⬆️
peer/conn.go 81.72% <0.00%> (+1.01%) ⬆️
agent/agent.go 68.49% <0.00%> (+2.19%) ⬆️
coderd/workspaceagents.go 61.78% <0.00%> (+2.85%) ⬆️
provisionersdk/serve.go 43.24% <0.00%> (+8.10%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4f7ceeb...a411b92. Read the comment docs.

@kylecarbs kylecarbs disabled auto-merge April 25, 2022 22:12
path.Join escaped the double slash!
@kylecarbs kylecarbs enabled auto-merge (squash) April 25, 2022 22:15
@kylecarbs kylecarbs merged commit 947e8f9 into main Apr 25, 2022
@kylecarbs kylecarbs deleted the buildinfourl branch April 25, 2022 22:22
kylecarbs added a commit that referenced this pull request Jun 10, 2022
path.Join escaped the double slash!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants