fix: Manually format external URL

kylecarbs · kylecarbs · commit 6239cf2b7329 · 2022-04-25T21:59:31.000Z
path.Join escaped the double slash!
diff --git a/buildinfo/buildinfo.go b/buildinfo/buildinfo.go
@@ -1,7 +1,7 @@
 package buildinfo
 
 import (
-	"path"
+	"fmt"
 	"runtime/debug"
 	"sync"
 	"time"
@@ -43,7 +43,7 @@ func ExternalURL() string {
 	if !valid {
 		return repo
 	}
-	return path.Join(repo, "commit", revision)
+	return fmt.Sprintf("%s/commit/%s", repo, revision)
 }
 
 // Time returns when the Git revision was published.
diff --git a/provisionerd/provisionerd_test.go b/provisionerd/provisionerd_test.go
@@ -501,6 +501,7 @@ func TestProvisionerd(t *testing.T) {
 
 	t.Run("ShutdownFromJob", func(t *testing.T) {
 		t.Parallel()
+		var completed sync.Once
 		var updated sync.Once
 		updateChan := make(chan struct{})
 		completeChan := make(chan struct{})
@@ -532,7 +533,9 @@ func TestProvisionerd(t *testing.T) {
 					}, nil
 				},
 				failJob: func(ctx context.Context, job *proto.FailedJob) (*proto.Empty, error) {
-					close(completeChan)
+					completed.Do(func() {
+						close(completeChan)
+					})
 					return &proto.Empty{}, nil
 				},
 			}), nil
