This tag is used to group security bugs by their general classification. These bugs allow an attacker to run JavaScript in another user's browser (Cross-site Scripting / XSS). See OWASP Top 10 2017 - A7
Parent project: Security-Team
This tag is used to group security bugs by their general classification. These bugs allow an attacker to run JavaScript in another user's browser (Cross-site Scripting / XSS). See OWASP Top 10 2017 - A7
Parent project: Security-Team
In T399414#11002373, @sbassett wrote:
- REL1_39: https://gerrit.wikimedia.org/r/1166022
- REL1_42: https://gerrit.wikimedia.org/r/1166021
Change #1166021 merged by SBassett:
[mediawiki/extensions/wikihiero@REL1_42] SECURITY: Insert system messages using .text() to prevent stored XSS
Change #1166022 merged by jenkins-bot:
[mediawiki/extensions/wikihiero@REL1_39] SECURITY: Insert system messages using .text() to prevent stored XSS
Ok, I've restored the affected change sets:
I had to modify a few syntactic things for the REL1_39 patch to get its (old) tests to pass. Namely use non-arrow notation and s/const/var/, which shouldn't be a big deal. It should be ready for a +2. I also pushed those same changes to the 1.42 change set since there are no tests anymore and I'd rather be safe than sorry re: back compat. If someone would like to +2 Verify/Confirm that change set, they should be able to do so now.
Change #1166021 restored by SBassett:
[mediawiki/extensions/wikihiero@REL1_42] SECURITY: Insert system messages using .text() to prevent stored XSS
Change #1166022 restored by SBassett:
[mediawiki/extensions/wikihiero@REL1_39] SECURITY: Insert system messages using .text() to prevent stored XSS
We can look at this during our clinic today, but just so it's clear, the Security-Team does not make any guarantees around supporting backports to older (even if supported) release branches. For anything under the supplemental security releases, we guarantee merging the patches to master/main and, if trivial, backports to other, supported release branches.
In T399414#10999212, @Lucas_Werkmeister_WMDE wrote:The backports for REL1_39 and REL1_42 were abandoned, presumably due to merge conflicts:
My guess would be that REL1_42 was abandoned because MediaWiki 1.42 is End of Life; MediaWiki 1.39 doesn’t become EoL until November 2025, but maybe that patch was abandoned by mistake / confusion for a similar reason.
The backports for REL1_39 and REL1_42 were abandoned, presumably due to merge conflicts:
Change #1166035 merged by Jly:
[mediawiki/extensions/MediaSearch@REL1_39] SECURITY: Insert message as text instead of HTML
Note: this has been merged to master and backported - https://gerrit.wikimedia.org/r/q/I3a1e21b6800ff4d813a33ee9fe9b7ccf070b6b2e
Note: this has been merged to master and backported - https://gerrit.wikimedia.org/r/q/I777fc55fef15c3b00df0db268af2b64cb2d6e381
Needs to wait for QA
Needs to wait for QA